From owner-freebsd-acpi@FreeBSD.ORG Mon Sep 20 15:59:54 2004 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 84E4416A4CE for ; Mon, 20 Sep 2004 15:59:54 +0000 (GMT) Received: from mail2.speakeasy.net (mail2.speakeasy.net [216.254.0.202]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5921843D5C for ; Mon, 20 Sep 2004 15:59:54 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: (qmail 1257 invoked from network); 20 Sep 2004 15:59:53 -0000 Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) encrypted SMTP for ; 20 Sep 2004 15:59:53 -0000 Received: from [10.50.40.210] (gw1.twc.weather.com [216.133.140.1]) (authenticated bits=0) by server.baldwin.cx (8.12.11/8.12.11) with ESMTP id i8KFxiu9023593; Mon, 20 Sep 2004 11:59:44 -0400 (EDT) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: freebsd-acpi@FreeBSD.org Date: Mon, 20 Sep 2004 11:59:33 -0400 User-Agent: KMail/1.6.2 References: <37F890616C995246BE76B3E6B2DBE05502071306@orsmsx403.amr.corp.intel.com> <20040919215548.GA37391@dhcp44.pn.xcllnt.net> <414E7689.80703@root.org> In-Reply-To: <414E7689.80703@root.org> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200409201159.33995.jhb@FreeBSD.org> X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on server.baldwin.cx cc: Sascha Klauder cc: "Moore, Robert" Subject: Re: trouble overriding DSDT X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Sep 2004 15:59:54 -0000 On Monday 20 September 2004 02:19 am, Nate Lawson wrote: > Marcel Moolenaar wrote: > > On Sun, Sep 19, 2004 at 02:07:58PM -0700, Nate Lawson wrote: > >>The right fix I think is to disable SSDT loading if we've overridden the > >>DSDT. Bob, what do you think? Marcel, we should fix this for 5.3R > >>because it will prevent people from using custom ASL easily. Another > >>quick fix would be to put a comment block around the disassembled SSDT > >>so it is there for inspection but doesn't affect recompilation. > > > > Tricky. The advantage of SSDTs is that it allows you to modularize, > > which means that one may want to be able to override a single SSDT. > > In that case, overriding the DSDT does not automaticly imply that > > none of the SSDTs should be loaded. > > > > If by default we do load SSDTs when overriding the DSDT (like we happen > > to do now by coincidence), we should not dump any SSDTs by default in > > acpidump(8) and vice versa. This also means that we should be able to > > just dump some SSDT and override just some SSDT. > > > > If overriding is acceptable to be an all or nothing approach, then > > acpidump(8) behaves correctly and we just need to stop loading SSDTs > > when the DSDT is overridden. > > Overriding is only for debugging or for known-bad machines. So I think > it's acceptable for the user to pass a combined/hacked DSDT+SSDT and > have it override all DSDT/SSDT tables. This is the way I'd like to > handle this. > > For now, I think it makes sense to put the SSDT in a comment block in > acpidump(8) so that recompiling and overriding works properly and the > SSDT is still available for examining. We can do the first fix in > -current but we need something for 5.3. > > Objections? I think it's a good idea to override all the DSDT+SSDT's when you load a new dsdt. Otherwise it just makes things much more complicated for the user to have to know what lives in different SSDT's, etc. If acpidump continues to dump a full table that can then be compiled into a single foo.dsdt that makes the user interface a lot simpler and easier to manage. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org