From owner-freebsd-stable Tue May 21 10:21:54 2002 Delivered-To: freebsd-stable@freebsd.org Received: from freebsd.dk (cpe.atm2-0-56339.0x50c6aa0a.abnxx2.customer.tele.dk [80.198.170.10]) by hub.freebsd.org (Postfix) with ESMTP id AECAF37B400; Tue, 21 May 2002 10:21:46 -0700 (PDT) Received: (from sos@localhost) by freebsd.dk (8.12.2/8.12.2) id g4LHLfSs029780; Tue, 21 May 2002 19:21:41 +0200 (CEST) (envelope-from sos) From: Søren Schmidt Message-Id: <200205211721.g4LHLfSs029780@freebsd.dk> Subject: Re: ATA observations in FreeBSD 4.6-RC In-Reply-To: <3CE9F4AB.E2F55150@svzserv.kemerovo.su> To: Eugene Grosbein Date: Tue, 21 May 2002 19:21:41 +0200 (CEST) Cc: freebsd-bugs@FreeBSD.ORG, Dmitry Morozovsky , Matthias Andree , freebsd-stable@FreeBSD.ORG, sos@FreeBSD.ORG Reply-To: sos@freebsd.dk X-Mailer: ELM [version 2.4ME+ PL94b (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=ISO-8859-1 Sender: owner-freebsd-stable@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG It seems Eugene Grosbein wrote: [ Charset KOI8-R unsupported, converting... ] > "S?ren Schmidt" wrote: > > > Of cause it should, and belive me I'm doing all I can to try get this > > nailed. But I do have a real life as well, and a fulltime job, 3 kids, > > vife and lots of other important things to care for, so excuse me if > > I dont work 24 hours a day on this problem... > > Of course. How about backing out new ATA code and stick with old > for the sake of 4.6-RELEASE stability? Yeah, right, thats to prove that progress comes hard or what ? Anyhow, could those haivng this problem try this patch: Index: ata-disk.c =================================================================== RCS file: /home/ncvs/src/sys/dev/ata/ata-disk.c,v retrieving revision 1.60.2.22 diff -u -r1.60.2.22 ata-disk.c --- ata-disk.c 11 Apr 2002 08:45:32 -0000 1.60.2.22 +++ ata-disk.c 21 May 2002 15:51:52 -0000 @@ -707,17 +707,17 @@ int device = adp->device->unit; if (adp->device->unit == ATA_MASTER) { - if (adp->device->channel->devices & ATA_ATA_SLAVE && - ((struct ad_softc *) - (adp->device->channel-> - device[ATA_DEV(ATA_SLAVE)].driver))->flags&AD_F_TAG_ENABLED) + if ((adp->device->channel->devices & ATA_ATA_SLAVE) && + (adp->device->channel->device[SLAVE].driver) && + ((struct ad_softc *) (adp->device->channel-> + device[SLAVE].driver))->flags & AD_F_TAG_ENABLED) device = ATA_SLAVE; } else { - if (adp->device->channel->devices & ATA_ATA_MASTER && - ((struct ad_softc *) - (adp->device->channel-> - device[ATA_DEV(ATA_MASTER)].driver))->flags&AD_F_TAG_ENABLED) + if ((adp->device->channel->devices & ATA_ATA_MASTER) && + (adp->device->channel->device[MASTER].driver) && + ((struct ad_softc *) (adp->device->channel-> + device[MASTER].driver))->flags & AD_F_TAG_ENABLED) device = ATA_MASTER; } if (device != adp->device->unit && -Søren To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-stable" in the body of the message