From owner-svn-src-all@FreeBSD.ORG Mon May 23 11:28:25 2011 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 710681065672; Mon, 23 May 2011 11:28:25 +0000 (UTC) (envelope-from edwin@mavetju.org) Received: from mail4out.barnet.com.au (mail4out.barnet.com.au [202.83.178.123]) by mx1.freebsd.org (Postfix) with ESMTP id 2BD838FC0A; Mon, 23 May 2011 11:28:25 +0000 (UTC) Received: by mail4out.barnet.com.au (Postfix, from userid 1001) id 852B337BF9D; Mon, 23 May 2011 21:28:23 +1000 (EST) X-Viruscan-Id: <4DDA44D70000610CE671B6@BarNet> Received: from mail4auth.barnet.com.au (mail4.barnet.com.au [202.83.178.125]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "*.barnet.com.au", Issuer "Equifax" (verified OK)) by mail4.barnet.com.au (Postfix) with ESMTPS id 13EC742206C; Mon, 23 May 2011 21:28:23 +1000 (EST) Received: from [10.204.250.208] (ppp121-45-190-113.lns6.syd7.internode.on.net [121.45.190.113]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (Client did not present a certificate) by mail4auth.barnet.com.au (Postfix) with ESMTPSA id 6CC0937BF8C; Mon, 23 May 2011 21:28:22 +1000 (EST) Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=iso-8859-1 From: Edwin Groothuis In-Reply-To: <20110523080030.GU31223@acme.spoerlein.net> Date: Mon, 23 May 2011 21:28:20 +1000 Content-Transfer-Encoding: quoted-printable Message-Id: <2A9B48C0-9849-4D11-99C1-2572E61EEED6@mavetju.org> References: <201105191309.p4JD9dXY038734@svn.freebsd.org> <20110522092937.GS31223@acme.spoerlein.net> <3AA8EEBF-4C35-41A3-9516-09044CADAD0C@mavetju.org> <20110523080030.GU31223@acme.spoerlein.net> To: =?iso-8859-1?Q?Ulrich_Sp=F6rlein?= X-Mailer: Apple Mail (2.1084) Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r222094 - head/share/misc X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 May 2011 11:28:25 -0000 On 23/05/2011, at 6:00 PM, Ulrich Sp=F6rlein wrote: > On Sun, 22.05.2011 at 20:16:47 +1000, Edwin Groothuis wrote: >>=20 >> On 22/05/2011, at 7:29 PM, Ulrich Sp=F6rlein wrote: >>=20 >>> On Thu, 19.05.2011 at 13:09:39 +0000, Edwin Groothuis wrote: >>>> Author: edwin >>>> Date: Thu May 19 13:09:39 2011 >>>> New Revision: 222094 >>>> URL: http://svn.freebsd.org/changeset/base/222094 >>>>=20 >>>> Log: >>>> Put AN back after finding out that tzsetup(1) will complain that >>>> it doesn't exist. It will be removed again once the tzdata = distribution >>>> files have been updated with the replacements for AN. >>>=20 >>> Wouldn't it be better to have tzsetup use iso3166.tab from the = tzdata >>> distribution, which is mostly guaranteed to be in sync with = zone.tab? >>=20 >>=20 >> Which opens a different can of worms. >> Duplicate file, with semi-similar contents. >>=20 >> Whenever there are changes in the distribution of the tzdata = iso3166.tab equivalent file, I check if they are in the /usr/share/misc = equivalent file. >> A warning to that file should be added that tzsetup uses it and that = they always should check tzsetup functionality before commiting it. >=20 > This seems way too brittle, as can be seen by random people going in = and > updating our iso3166 file. I'd rather take a tiny duplication of files > than manual fixups needed to unbreak installing. >=20 > AFAICS only tzsetup and sysinstall depend on /usr/share/misc/iso3166, That are only the tools in the base system that you know about. It has been part of the base system long enough that people think they = can rely on it. Some of my tools do, for sure. Edwin=