Date: Mon, 23 May 2011 21:28:20 +1000 From: Edwin Groothuis <edwin@mavetju.org> To: =?iso-8859-1?Q?Ulrich_Sp=F6rlein?= <uqs@spoerlein.net> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r222094 - head/share/misc Message-ID: <2A9B48C0-9849-4D11-99C1-2572E61EEED6@mavetju.org> In-Reply-To: <20110523080030.GU31223@acme.spoerlein.net> References: <201105191309.p4JD9dXY038734@svn.freebsd.org> <20110522092937.GS31223@acme.spoerlein.net> <3AA8EEBF-4C35-41A3-9516-09044CADAD0C@mavetju.org> <20110523080030.GU31223@acme.spoerlein.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On 23/05/2011, at 6:00 PM, Ulrich Sp=F6rlein wrote: > On Sun, 22.05.2011 at 20:16:47 +1000, Edwin Groothuis wrote: >>=20 >> On 22/05/2011, at 7:29 PM, Ulrich Sp=F6rlein wrote: >>=20 >>> On Thu, 19.05.2011 at 13:09:39 +0000, Edwin Groothuis wrote: >>>> Author: edwin >>>> Date: Thu May 19 13:09:39 2011 >>>> New Revision: 222094 >>>> URL: http://svn.freebsd.org/changeset/base/222094 >>>>=20 >>>> Log: >>>> Put AN back after finding out that tzsetup(1) will complain that >>>> it doesn't exist. It will be removed again once the tzdata = distribution >>>> files have been updated with the replacements for AN. >>>=20 >>> Wouldn't it be better to have tzsetup use iso3166.tab from the = tzdata >>> distribution, which is mostly guaranteed to be in sync with = zone.tab? >>=20 >>=20 >> Which opens a different can of worms. >> Duplicate file, with semi-similar contents. >>=20 >> Whenever there are changes in the distribution of the tzdata = iso3166.tab equivalent file, I check if they are in the /usr/share/misc = equivalent file. >> A warning to that file should be added that tzsetup uses it and that = they always should check tzsetup functionality before commiting it. >=20 > This seems way too brittle, as can be seen by random people going in = and > updating our iso3166 file. I'd rather take a tiny duplication of files > than manual fixups needed to unbreak installing. >=20 > AFAICS only tzsetup and sysinstall depend on /usr/share/misc/iso3166, That are only the tools in the base system that you know about. It has been part of the base system long enough that people think they = can rely on it. Some of my tools do, for sure. Edwin=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2A9B48C0-9849-4D11-99C1-2572E61EEED6>