From owner-svn-src-head@FreeBSD.ORG Mon Sep 15 16:31:22 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id DBE40239; Mon, 15 Sep 2014 16:31:21 +0000 (UTC) Received: from mx0a-0016ce01.pphosted.com (mx0a-0016ce01.pphosted.com [67.231.148.157]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B5B1FBE3; Mon, 15 Sep 2014 16:31:21 +0000 (UTC) Received: from pps.filterd (m0045602.ppops.net [127.0.0.1]) by mx0a-0016ce01.pphosted.com (8.14.5/8.14.5) with SMTP id s8FGJYu7014812; Mon, 15 Sep 2014 09:31:15 -0700 Received: from avcashub1.qlogic.com (avcashub2.qlogic.com [198.70.193.116]) by mx0a-0016ce01.pphosted.com with ESMTP id 1patsxh2nk-1 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT); Mon, 15 Sep 2014 09:31:15 -0700 Received: from AVMB1.qlogic.org ([fe80::c919:8cc:f3ba:c727]) by avcashub2.qlogic.org ([::1]) with mapi id 14.02.0387.000; Mon, 15 Sep 2014 09:31:15 -0700 From: David Somayajulu To: "Andrey V. Elsukov" , David C Somayajulu , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Subject: RE: svn commit: r265703 - in head: share/man/man4 sys/dev/bce sys/dev/bxe sys/modules/bce Thread-Topic: svn commit: r265703 - in head: share/man/man4 sys/dev/bce sys/dev/bxe sys/modules/bce Thread-Index: AQHPavVn2jiHLJpVI0alLPpTagQEkZwC40GAgABIDUA= Date: Mon, 15 Sep 2014 16:31:13 +0000 Message-ID: <49F5640B08EAA94DAF2F6B6145E6A08A012866587B@AVMB1.qlogic.org> References: <201405081940.s48Jebh5041824@svn.freebsd.org> <54167255.5090806@FreeBSD.org> In-Reply-To: <54167255.5090806@FreeBSD.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.1.4.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=nai engine=5600 definitions=7561 signatures=670520 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=7.0.1-1402240000 definitions=main-1409150142 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Sep 2014 16:31:22 -0000 Hi Andrey, When I didn't have the clean override, "make clean" was not cleaning prope= rly when I built a standalone loadable driver. Perhaps we can change "clean= " in bxe/Makefile and bce/Makefile to "dclean". Thanks David S. -----Original Message----- From: Andrey V. Elsukov [mailto:ae@FreeBSD.org] Sent: Sunday, September 14, 2014 10:00 PM To: David C Somayajulu; src-committers@freebsd.org; svn-src-all@freebsd.org= ; svn-src-head@freebsd.org Subject: Re: svn commit: r265703 - in head: share/man/man4 sys/dev/bce sys/= dev/bxe sys/modules/bce On 08.05.2014 23:40, David C Somayajulu wrote: > Author: davidcs > Date: Thu May 8 19:40:37 2014 > New Revision: 265703 > URL: http://svnweb.freebsd.org/changeset/base/265703 > Modified: head/sys/modules/bce/Makefile > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/modules/bce/Makefile Thu May 8 19:35:29 2014 (r2= 65702) > +++ head/sys/modules/bce/Makefile Thu May 8 19:40:37 2014 (r2= 65703) > @@ -5,4 +5,9 @@ SRCS=3D opt_bce.h if_bce.c miibus_if.h mii > > #CFLAGS +=3D -DBCE_DEBUG=3D0 > > +clean: > + rm -f opt_bdg.h device_if.h bus_if.h pci_if.h export_syms > + rm -f *.o *.kld *.ko > + rm -f @ machine x86 miibus_if.h miidevs.h opt_bce.h > + > .include Hi, why did you override 'clean' target? It works well by default, but now some files don't deleted, e.g. when you b= uild modules with DEBUG_FLAGS. Also the same problem with if_bxe(4) module. -- WBR, Andrey V. Elsukov ________________________________ This message and any attached documents contain information from QLogic Cor= poration or its wholly-owned subsidiaries that may be confidential. If you = are not the intended recipient, you may not read, copy, distribute, or use = this information. If you have received this transmission in error, please n= otify the sender immediately by reply e-mail and then delete this message.