From owner-freebsd-net@FreeBSD.ORG  Tue Jan 28 23:29:00 2014
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id DDF75FB3
 for <freebsd-net@freebsd.org>; Tue, 28 Jan 2014 23:29:00 +0000 (UTC)
Received: from mail-ig0-x232.google.com (mail-ig0-x232.google.com
 [IPv6:2607:f8b0:4001:c05::232])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id AC74A158D
 for <freebsd-net@freebsd.org>; Tue, 28 Jan 2014 23:29:00 +0000 (UTC)
Received: by mail-ig0-f178.google.com with SMTP id uq10so3086975igb.5
 for <freebsd-net@freebsd.org>; Tue, 28 Jan 2014 15:29:00 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:in-reply-to:references:date:message-id:subject
 :from:to:content-type;
 bh=zClW/XfweItmgB6x4uQgGMoKtWGxMYr9oVqjZycfAAw=;
 b=tDJtkBk16eYXhOvovvf+jHrFYa/P4ICK16u5ENaY7dexEogwzmpJOn7rKW79pdK+xs
 Rkc1U9G5sQvEk5kqzHThK2Nvc1c0Q4MGQVJhjvchYEuhMKAtbR/R8k0l+tuZ/nHJ/tyg
 5Le19Hg1lFmMIlt587eY6tSaEnJfaE7TplA6FpKFCn00EJq/FSUb4yn7YnVWIYWKlwPS
 2c9gid5NBGli9pnQsjBlizG1nGjGv6YdRnYWlcZeqeTJkWY7JsRjbnW9nNeIdF4WJHUZ
 JerpkkShDSvLP/D1Kw/4wzj45oQReNO3L+rs4c/1TPdexfQJlhd+tM4WMJcHseuYyVjU
 WhEg==
MIME-Version: 1.0
X-Received: by 10.51.17.101 with SMTP id gd5mr5486745igd.25.1390951739913;
 Tue, 28 Jan 2014 15:28:59 -0800 (PST)
Sender: jdavidlists@gmail.com
Received: by 10.42.170.8 with HTTP; Tue, 28 Jan 2014 15:28:59 -0800 (PST)
In-Reply-To: <20140128021450.GY13704@funkthat.com>
References: <20140128002826.GU13704@funkthat.com>
 <1415339672.17282775.1390872779067.JavaMail.root@uoguelph.ca>
 <20140128021450.GY13704@funkthat.com>
Date: Tue, 28 Jan 2014 18:28:59 -0500
X-Google-Sender-Auth: kfx4cadvc10boT96qtjos3WGgc0
Message-ID: <CABXB=RTa_buG0k7oFaQcKpE0EFyS+pxMzx6aKCzXkP0tQ9As2g@mail.gmail.com>
Subject: Re: Terrible NFS performance under 9.2-RELEASE?
From: J David <j.david.lists@gmail.com>
To: freebsd-net@freebsd.org, jmg@funkthat.com
Content-Type: text/plain; charset=ISO-8859-1
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net/>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Jan 2014 23:29:00 -0000

On Mon, Jan 27, 2014 at 9:14 PM, John-Mark Gurney <jmg@funkthat.com> wrote:
> P.S. if someone wants to submit a patch to mbuf.9 to update the docs
> that would be helpful... I'll review and commit...  and m_append is
> also undocumented...

Would that look something like this be a start in that direction?

http://pastebin.com/UVir1BET

This is all very new to me, so I apologize if that's completely wrong.

m_append does appear to be documented, it's between m_adj and
m_prepend.  (At least it is on 9.2, which is the latest tree I have
access to.)

It does also look like m_getm is just a macro in mbuf.h that calls
m_getm2 with flags set to M_PKTHDR, not a function as described in the
man page.  It was not immediately obvious if that was intentional or
something that should be fixed or if it's intentionally meant to be
treated as a function from an API standpoint.

Thanks!