Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 28 Jan 2014 18:28:59 -0500
From:      J David <j.david.lists@gmail.com>
To:        freebsd-net@freebsd.org, jmg@funkthat.com
Subject:   Re: Terrible NFS performance under 9.2-RELEASE?
Message-ID:  <CABXB=RTa_buG0k7oFaQcKpE0EFyS%2BpxMzx6aKCzXkP0tQ9As2g@mail.gmail.com>
In-Reply-To: <20140128021450.GY13704@funkthat.com>
References:  <20140128002826.GU13704@funkthat.com> <1415339672.17282775.1390872779067.JavaMail.root@uoguelph.ca> <20140128021450.GY13704@funkthat.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jan 27, 2014 at 9:14 PM, John-Mark Gurney <jmg@funkthat.com> wrote:
> P.S. if someone wants to submit a patch to mbuf.9 to update the docs
> that would be helpful... I'll review and commit...  and m_append is
> also undocumented...

Would that look something like this be a start in that direction?

http://pastebin.com/UVir1BET

This is all very new to me, so I apologize if that's completely wrong.

m_append does appear to be documented, it's between m_adj and
m_prepend.  (At least it is on 9.2, which is the latest tree I have
access to.)

It does also look like m_getm is just a macro in mbuf.h that calls
m_getm2 with flags set to M_PKTHDR, not a function as described in the
man page.  It was not immediately obvious if that was intentional or
something that should be fixed or if it's intentionally meant to be
treated as a function from an API standpoint.

Thanks!



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CABXB=RTa_buG0k7oFaQcKpE0EFyS%2BpxMzx6aKCzXkP0tQ9As2g>