From owner-freebsd-bugs Wed Jan 26 14:20: 5 2000 Delivered-To: freebsd-bugs@freebsd.org Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (Postfix) with ESMTP id CD0CE14D3C for ; Wed, 26 Jan 2000 14:20:03 -0800 (PST) (envelope-from gnats@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.9.3/8.9.2) id OAA59345; Wed, 26 Jan 2000 14:20:03 -0800 (PST) (envelope-from gnats@FreeBSD.org) Date: Wed, 26 Jan 2000 14:20:03 -0800 (PST) Message-Id: <200001262220.OAA59345@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org Cc: From: "Rodney W. Grimes" Subject: Re: bin/10342: putenv(3) unnecessarily calls strdup/free Reply-To: "Rodney W. Grimes" Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org The following reply was made to PR bin/10342; it has been noted by GNATS. From: "Rodney W. Grimes" To: peter.jeremy@alcatel.com.au (Peter Jeremy) Cc: FreeBSD-gnats-submit@FreeBSD.ORG Subject: Re: bin/10342: putenv(3) unnecessarily calls strdup/free Date: Wed, 26 Jan 2000 14:18:23 -0800 (PST) > Hi Rod, > > I know it's been a while, but you were the last person to touch > /usr/src/lib/libc/stdlib/putenv.c. Could you please consider > applying the following to close PR bin/10342: No I won't make this change: a) This is tried and true tested code that has not been modified since 4.4BSD Lite. b) The man page says ``the given arguments name and value may be appended and prepended, respectively, with an equal sign ``=''.'' It does not say that you can have additional stuff after the =, your patch leaves stuff after the =. The PR eludes to a memory leak, can you be more specific on exactly how this memory leak occurs as I do not see a memory leak in putenv as the code is now. -- Rod Grimes - KD7CAX @ CN85sl - (RWG25) rgrimes@gndrsh.dnsmgr.net To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message