From owner-freebsd-bugs@FreeBSD.ORG Sun Sep 12 02:40:25 2004 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D9FF416A4CE for ; Sun, 12 Sep 2004 02:40:24 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 96A4443D2F for ; Sun, 12 Sep 2004 02:40:24 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.11/8.12.11) with ESMTP id i8C2eO7g086970 for ; Sun, 12 Sep 2004 02:40:24 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i8C2eO8L086969; Sun, 12 Sep 2004 02:40:24 GMT (envelope-from gnats) Resent-Date: Sun, 12 Sep 2004 02:40:24 GMT Resent-Message-Id: <200409120240.i8C2eO8L086969@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Dan Lukes Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AD9F916A4CE for ; Sun, 12 Sep 2004 02:37:44 +0000 (GMT) Received: from kulesh.obluda.cz (kulesh.obluda.cz [193.179.22.243]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8445C43D31 for ; Sun, 12 Sep 2004 02:37:43 +0000 (GMT) (envelope-from dan@obluda.cz) Received: from kulesh.obluda.cz (localhost.eunet.cz [127.0.0.1]) by kulesh.obluda.cz (8.13.1/8.13.1) with ESMTP id i8C2bfmk007099 for ; Sun, 12 Sep 2004 04:37:42 +0200 (CEST) (envelope-from dan@obluda.cz) Received: (from root@localhost) by kulesh.obluda.cz (8.13.1/8.13.1/Submit) id i8C2bfRG007098 for FreeBSD-gnats-submit@freebsd.org; Sun, 12 Sep 2004 04:37:41 +0200 (CEST) (envelope-from dan@obluda.cz) Message-Id: <200409120237.i8C2bfRG007098@kulesh.obluda.cz> Date: Sun, 12 Sep 2004 04:37:41 +0200 (CEST) From: Dan Lukes To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: bin/71619: [PATCH] cleanup of the usr.sbin/tcpdump code X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Dan Lukes List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Sep 2004 02:40:25 -0000 >Number: 71619 >Category: bin >Synopsis: [PATCH] cleanup of the usr.sbin/tcpdump code >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Sep 12 02:40:24 GMT 2004 >Closed-Date: >Last-Modified: >Originator: Dan Lukes >Release: FreeBSD 5.3-BETA3 i386 >Organization: Obludarium >Environment: System: FreeBSD kulesh.obluda.cz 5.3-BETA3 FreeBSD 5.3-BETA3 #8: Sun Sep 5 07:06:40 CEST 2004 dan@kulesh.obluda.cz:/usr/obj/usr/src/sys/Dan i386 usr.sbin/tcpdump/tcpslice/tcpslice.c,v 1.12 2002/01/19 23:20:02 dillon usr.sbin/tcpdump/tcpslice/gwtm2secs.c,v 1.4 1999/08/28 05:11:32 peter >Description: There are more than 5000 warnings issued during "make buildworld". Some of them are false positives, but some of them are sign of true errors. Nobody is upset by warnings due it's amount, so some errors remain uncorrected. I want to cleanup the code-base from warnings, so warnings will become "attention mark" again. usr.sbin/tcpdump/tcpslice/gwtm2secs.c:49: warning: suggest explicit braces to avoid ambiguous `else' usr.sbin/tcpdump/tcpslice/tcpslice.c:198: warning: implicit declaration of function `_long_to_time' >How-To-Repeat: N/A >Fix: *** usr.sbin/tcpdump/gwtm2secs.c.ORIG Mon Sep 6 11:13:34 2004 --- usr.sbin/tcpdump/gwtm2secs.c Mon Sep 6 11:14:33 2004 *************** *** 46,56 **** * 2-digit years are either 19xx or 20xx - a simple heuristic * distinguishes them, since we can't represent any time < 1970. */ ! if ( year < 100 ) if ( year >= 70 ) year += 1900; else year += 2000; days = 0; for ( i = 1970; i < year; ++i ) --- 46,58 ---- * 2-digit years are either 19xx or 20xx - a simple heuristic * distinguishes them, since we can't represent any time < 1970. */ ! if ( year < 100 ) ! { if ( year >= 70 ) year += 1900; else year += 2000; + } days = 0; for ( i = 1970; i < year; ++i ) *** usr.sbin/tcpdump/tcpslice.c.ORIG Sun Jan 20 00:20:02 2002 --- usr.sbin/tcpdump/tcpslice.c Mon Sep 6 11:20:36 2004 *************** *** 35,40 **** --- 35,41 ---- */ #include + #include #include "tcpslice.h" int tflag = 0; /* global that util routines are sensitive to */ >Release-Note: >Audit-Trail: >Unformatted: