From owner-freebsd-current@FreeBSD.ORG Tue Aug 26 21:22:27 2014 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id DD769D6E; Tue, 26 Aug 2014 21:22:26 +0000 (UTC) Received: from mail-wi0-x231.google.com (mail-wi0-x231.google.com [IPv6:2a00:1450:400c:c05::231]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B51013FA9; Tue, 26 Aug 2014 21:22:25 +0000 (UTC) Received: by mail-wi0-f177.google.com with SMTP id ho1so4830465wib.4 for ; Tue, 26 Aug 2014 14:22:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type:content-transfer-encoding; bh=fEdO38MZwrU+pMfm4QOGZL2b8o5RfvgS8MFkZRVCmxA=; b=g3XqtREEh3x/an2SIwXIuga94t79I/zhc+6wDMT0z0y4fPx8adP0yqSwMDh5AfMrPN OeI/iT8AVeND07bc63+IeqSxeXm8cxRGoa7QuYWbl8X8PsyP+5nnb+AVU7jj/bwfM5Wo Zu541TiEHsl0nj22bDlC6wSBmaTbuCdHrdlIILI/ZJzunnrc+atWvwVD2L2R6+fzzhTv s40+Ma6f+Is7xN1VPDe0bjQ4h/IXdhP5/l7Vqr22JZpYwh0vEe/CYm3lKMXlY2oGAI2d GAaEROfmCoLBVLJ0ZurvZyVrNsPHEhm47om8rlFr++NWsAndSqNncqfgJvnGIfVouwYw lEuw== MIME-Version: 1.0 X-Received: by 10.180.189.195 with SMTP id gk3mr8849488wic.82.1409088143887; Tue, 26 Aug 2014 14:22:23 -0700 (PDT) Sender: asomers@gmail.com Received: by 10.194.126.1 with HTTP; Tue, 26 Aug 2014 14:22:23 -0700 (PDT) In-Reply-To: <20140826195140.GA10143@charmander.home> References: <522300E3.6050303@rawbw.com> <2204059.7tqSNWvxzC@ralph.baldwin.cx> <201408261515.32146.jhb@freebsd.org> <20140826195140.GA10143@charmander.home> Date: Tue, 26 Aug 2014 15:22:23 -0600 X-Google-Sender-Auth: fVlBnlL5R2Oy1gKYHY9bbsfFbWc Message-ID: Subject: Re: [PATCH] Packet loss when 'control' messages are present with large data (sendmsg(2)) From: Alan Somers To: Mark Johnston Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: current@freebsd.org, Alan Somers , Harald Schmalzbauer , FreeBSD CURRENT , "net@freebsd.org" , Yuri X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Aug 2014 21:22:27 -0000 On Tue, Aug 26, 2014 at 1:51 PM, Mark Johnston wrote: > On Tue, Aug 26, 2014 at 03:15:31PM -0400, John Baldwin wrote: >> On Tuesday, August 26, 2014 11:05:12 am Alan Somers wrote: >> > On Mon, Aug 25, 2014 at 1:52 PM, John Baldwin wrote: >> > > On Friday, August 22, 2014 01:34:28 PM Harald Schmalzbauer wrote: >> > >> Bez=C3=BCglich Yuri's Nachricht vom 02.09.2013 06:54 (localtime): >> > >> > Please check in this patch: >> > >> > http://www.freebsd.org/cgi/query-pr.cgi?pr=3D181741 >> > >> > Please MFC into 9.X >> > >> > >> > >> > Description of the problem is within PR. >> > >> > >> > >> > Thanks, >> > >> > Yuri >> > >> >> > >> Hello, >> > >> >> > >> I guess this fix should make it into 10.1. >> > >> Can someone check please? >> > > >> > > A fix has to make into HEAD first. I've cc'd Alan who responded to = the bug. >> > > Alan, note that glebius@ already committed the test case to HEAD a w= hile ago. >> > >> > First, Gleb's testcase needs to be converted to ATF. This would be a >> > good exercise for anybody who's new to ATF and wants some practice. >> > Anybody interested? >> >> While that would be nice, I don't know that it's quite fair to require t= he >> test to be converted before working on a possible fix. The existing tes= t >> doesn't seem that hard to run by hand: >> >> % cd work/freebsd/head/tools/regression/sockets/unix_passfd/ >> % make >> ... >> % > ./unix_passfd >> beginning test1-simplesendfd >> test1-simplesendfd passed >> ... >> beginning test8-rigths+creds+payload >> unix_passfd: test8-rigths+creds+payload: recvmsg: 24 bytes received >> >> I only say this because in the bug followup you seemed to have described= a >> possible solution so it seems that you would be able to develop a fix qu= icker >> than other folks since you are already familiar with the issues involved= . >> (Also, you've fixed other related issues recently.) > > As it happens, I went ahead and did this anyway: > https://reviews.freebsd.org/D689 BTW, is it just me, or is arcanist insanely slow? Usually "arc diff --create" or "arc diff --update" take many minutes to complete. Like, 30 minutes. I've been trying to do "arc patch" for nearly an hour now, but it hasn't completed yet.