From owner-freebsd-current  Fri Feb  6 01:48:25 1998
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Received: (from majordom@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id BAA09465
          for current-outgoing; Fri, 6 Feb 1998 01:48:25 -0800 (PST)
          (envelope-from owner-freebsd-current@FreeBSD.ORG)
Received: from ns1.yes.no (ns1.yes.no [195.119.24.10])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id BAA09459
          for <freebsd-current@FreeBSD.ORG>; Fri, 6 Feb 1998 01:48:22 -0800 (PST)
          (envelope-from eivind@bitbox.follo.net)
Received: from bitbox.follo.net (bitbox.follo.net [194.198.43.36])
	by ns1.yes.no (8.8.7/8.8.7) with ESMTP id JAA21781;
	Fri, 6 Feb 1998 09:48:19 GMT
Received: (from eivind@localhost)
	by bitbox.follo.net (8.8.6/8.8.6) id KAA08355;
	Fri, 6 Feb 1998 10:48:18 +0100 (MET)
Message-ID: <19980206104818.51201@follo.net>
Date: Fri, 6 Feb 1998 10:48:18 +0100
From: Eivind Eklund <eivind@yes.no>
To: Dmitrij Tejblum <dima@tejblum.dnttm.rssi.ru>
Cc: Eivind Eklund <eivind@yes.no>, freebsd-current@FreeBSD.ORG
Subject: Re: DIAGNOSTIC kernels broken
References: <19980206010712.58740@follo.net> <199802060943.MAA01329@tejblum.dnttm.rssi.ru>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Mailer: Mutt 0.88e
In-Reply-To: <199802060943.MAA01329@tejblum.dnttm.rssi.ru>; from Dmitrij Tejblum on Fri, Feb 06, 1998 at 12:43:20PM +0300
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG
X-To-Unsubscribe: mail to majordomo@FreeBSD.org "unsubscribe current"

On Fri, Feb 06, 1998 at 12:43:20PM +0300, Dmitrij Tejblum wrote:
> Eivind Eklund wrote:
> > On Fri, Feb 06, 1998 at 02:43:02AM +0300, Dmitrij Tejblum wrote:
> > > vm/vm_zone.h depends on DIAGNOSTIC but doesn't include "opt_diagnostic.h".
>               ^^
> > 
> > Something is weird with your setup, I believe.  vm_zone.c includes
>                                                          ^^
> > opt_diagnostic.h as of revision 1.16, which was part of the "Turn DIAGNOSTIC
> > into a new-style option" commit.
> 
> I talk about vm_zone.h, not vm_zone.c. vm_zone.h contains several inline 
> functions, which depends on DIAGNOSTIC. These functions is part of vm_zone 
> external interface, and used in such files as kern_fork.c, and kern_exit.c, 
> and others, which doesn't include opt_diagnostic.h.

Guilty as charged.  They don't matter for an SMP kernel, which is why
I didn't notice :-(

I'm backing this change out and putting DIAGNOSTIC in opt_global.h.
Maintaining it separately is more likely to go wrong than not.

Eivind.