From owner-freebsd-net@FreeBSD.ORG  Mon Feb  2 11:42:41 2015
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id E18886FC
 for <freebsd-net@FreeBSD.org>; Mon,  2 Feb 2015 11:42:41 +0000 (UTC)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id C8B8E8B4
 for <freebsd-net@FreeBSD.org>; Mon,  2 Feb 2015 11:42:41 +0000 (UTC)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t12Bgfax026529
 for <freebsd-net@FreeBSD.org>; Mon, 2 Feb 2015 11:42:41 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-net@FreeBSD.org
Subject: [Bug 194672] [carp] Changing advskew to 0 from another value doesn't
 work
Date: Mon, 02 Feb 2015 11:42:42 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: kern
X-Bugzilla-Version: 10.1-RC2
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: Affects Some People
X-Bugzilla-Who: commit-hook@freebsd.org
X-Bugzilla-Status: New
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-194672-2472-IVZfrCRb9n@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-194672-2472@https.bugs.freebsd.org/bugzilla/>
References: <bug-194672-2472@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net/>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 02 Feb 2015 11:42:42 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=194672

--- Comment #7 from commit-hook@freebsd.org ---
A commit references this bug:

Author: loos
Date: Mon Feb  2 11:42:36 UTC 2015
New revision: 278075
URL: https://svnweb.freebsd.org/changeset/base/278075

Log:
  MFC r276751:

  Remove the check that prevent carp(4) advskew to be set to '0'.

  CARP devices are created with advskew set to '0' and once you set it to
  any other value in the valid range (0..254) you can't set it back to zero.

  The code in question is also used to prevent that zeroed values overwrite
  the CARP defaults when a new CARP device is created.  Since advskew already
  defaults to '0' for newly created devices and the new value is guaranteed
  to be within the valid range, it is safe to overwrite it here.

  PR:        194672
  Reported by:    cmb@pfsense.org

Changes:
_U  stable/10/
  stable/10/sys/netinet/ip_carp.c

-- 
You are receiving this mail because:
You are the assignee for the bug.