From owner-freebsd-arch Mon Feb 12 13:19: 5 2001 Delivered-To: freebsd-arch@freebsd.org Received: from gratis.grondar.za (grouter.grondar.za [196.7.18.65]) by hub.freebsd.org (Postfix) with ESMTP id 2F06A37B491 for ; Mon, 12 Feb 2001 13:18:58 -0800 (PST) Received: from grondar.za (root@gratis.grondar.za [196.7.18.133]) by gratis.grondar.za (8.11.1/8.11.1) with ESMTP id f1CLIo926029 for ; Mon, 12 Feb 2001 23:18:53 +0200 (SAST) (envelope-from mark@grondar.za) Message-Id: <200102122118.f1CLIo926029@gratis.grondar.za> To: arch@freebsd.org Subject: LOCORE considered evil... Date: Mon, 12 Feb 2001 23:19:24 +0200 From: Mark Murray Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Hi In my grovellings through the kernel, I became rather annoyed with the LOCORE macro. This used to mean (inside #ifdef LOCORE/#endif) "this code is inside locore.s, do not show any C code". These days it has come to mean 'this (#if .../#endif) code is assmbler code, please don't bother me with C'. Thus, LOCORE is meaningless, and counter-intuitive. I have replaced LOCORE (and _LOCORE) with __ASM__, and put the patch up at http://people.freebsd.org/~markm/patches/sys.LOCORE.diff. Please test and review. Please resist bikeshedding :-) (It works on i386, i386/LINT compiles, and alpha/GENERIC compiles. Alpha/Generic has not been runtested). There is a _tiny_ userland patch that goes with this. Utterly trivial. (Available on request) M -- Mark Murray Warning: this .sig is umop ap!sdn To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message