From nobody Sat Oct 26 21:06:00 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XbXHr2sf2z5bBLJ; Sat, 26 Oct 2024 21:06:00 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XbXHr2KZxz4FRJ; Sat, 26 Oct 2024 21:06:00 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1729976760; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=1cc9nH8gNP4Sjujs30A8O0VzAwh6SV8s5jh//OrAuOs=; b=CYXUxKoMIdn1HaBLrxm7qHloP+UyXrJZjwvgFMugHIPD3/2mcNLKhhEA5QvcXk895cqnE/ NE5LiTztldMPpriEe0dzPF2EEEYNKzUszuCxDAVVsnkMKIsdi+usiKDDwAbvu0Xm1AABFy 2UXVa45zX+rdyCq4oJ3xJQeUFkPJV/Rn+sMGmSX3XHCCK9y79SrFMbMDCjt2dlbajB/hbm NB6IQJmeClXfLixqAptnmaBUSX/FOnQG6W5kbZAYkaCFPc5YrtY/2pOusaVgXZX97iT3m4 NPBCMhKJYGv+uqxZTzdt48OqV0LfvRhc3exLeOwe4hqDAro2Fw6DV0eiHzakRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1729976760; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=1cc9nH8gNP4Sjujs30A8O0VzAwh6SV8s5jh//OrAuOs=; b=Ra2k4poGZ8MgPwgumJdJpU8mpsRzOGZ+CGTH9VfrQQKuDQwp1JId2VWpCJK7nk/xJVzZKl FLD8F4aVIkgrOpBoh0e+Ag+9QhajOcrw2118emMkWSMOSTHGt5QS/+BEeFxGUZv8nd5iMq u2PR7gSseRZ7TObp51P9T4nhWiFp+pLm0Y70dcYPe+Pyc0IRtVDmctBfaMHy2AAuvgkyU1 fY07i+1F+XKg98qoR5Qf78uQFbNBJoVxKCy198br7eL+KMQTnpVHGb0Bd64z9yWh5wZ0Ye 81sklwujTgyYfOFD6xBoj5b2P6lHUmzLLlWnXujTTGO7xD8ASqT7o4L/jA83Lw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1729976760; a=rsa-sha256; cv=none; b=NoF/Y+VG6eKVZLTObCX4pEnrKn/3KCvcRjB1007JpXF3JK6e4gtdcQSCjiZjJbDAhfZXN9 VtN6qeRcpc/olI/yNtTpNpV8xnMdz4qEYEE2Wr5weEN2QFRtkPCk8fxwONnVnrEWt1PMWv QNdOefk3PIorq4sYVpcMqOdP5Vtj3/36QqSyyKO1eXJF1PKgtfKPvKSdBaTttGKXabgOyr a+uxVKKcM+2Kd8bVB5r9rQ82dkbhQ87PV698msOhZkMXCB9bx2SMOrAZskAnP3V7bPaOWj MulRBOxyL3iSVyr5oZR/Y0PvNKCYUYHX3nKo/o35Ude+GDamLyrSvefIerHfHg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4XbXHr1nfvzQSN; Sat, 26 Oct 2024 21:06:00 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 49QL60EU067132; Sat, 26 Oct 2024 21:06:00 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 49QL60Fv067129; Sat, 26 Oct 2024 21:06:00 GMT (envelope-from git) Date: Sat, 26 Oct 2024 21:06:00 GMT Message-Id: <202410262106.49QL60Fv067129@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: 35d05a14ed7e - main - igc: Remove a bogus register write in igc_if_queues_free() List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 35d05a14ed7e9935be1ed0fe965b91aaaa4c92ef Auto-Submitted: auto-generated The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=35d05a14ed7e9935be1ed0fe965b91aaaa4c92ef commit 35d05a14ed7e9935be1ed0fe965b91aaaa4c92ef Author: Mark Johnston AuthorDate: 2024-10-26 21:04:59 +0000 Commit: Mark Johnston CommitDate: 2024-10-26 21:05:40 +0000 igc: Remove a bogus register write in igc_if_queues_free() As explained in PR 277038, iflib calls IFDI_DETACH() and then IFDI_QUEUES_FREE(). With igc, the latter writes to a register after it has been unmapped. igc_if_detach() already calls igc_release_hw_control(), and looking at callers of igc_if_queues_free(), that appears to be sufficient. So, just remove the igc_release_hw_control() call. PR: 277038 Reported by: Mike Belanger Reviewed by: kbowling Tested by: kbowling MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D47293 --- sys/dev/igc/if_igc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sys/dev/igc/if_igc.c b/sys/dev/igc/if_igc.c index dd89b27e134c..38fb1406b1c1 100644 --- a/sys/dev/igc/if_igc.c +++ b/sys/dev/igc/if_igc.c @@ -2050,8 +2050,6 @@ igc_if_queues_free(if_ctx_t ctx) sc->rx_queues = NULL; } - igc_release_hw_control(sc); - if (sc->mta != NULL) { free(sc->mta, M_DEVBUF); }