From owner-svn-src-all@FreeBSD.ORG  Mon Oct 15 14:37:07 2012
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id 37D1B5EE;
 Mon, 15 Oct 2012 14:37:07 +0000 (UTC)
 (envelope-from glebius@FreeBSD.org)
Received: from cell.glebius.int.ru (glebius.int.ru [81.19.64.117])
 by mx1.freebsd.org (Postfix) with ESMTP id A3F118FC14;
 Mon, 15 Oct 2012 14:37:06 +0000 (UTC)
Received: from cell.glebius.int.ru (localhost [127.0.0.1])
 by cell.glebius.int.ru (8.14.5/8.14.5) with ESMTP id q9FEawgG020039;
 Mon, 15 Oct 2012 18:36:58 +0400 (MSK)
 (envelope-from glebius@FreeBSD.org)
Received: (from glebius@localhost)
 by cell.glebius.int.ru (8.14.5/8.14.5/Submit) id q9FEawJq020038;
 Mon, 15 Oct 2012 18:36:58 +0400 (MSK)
 (envelope-from glebius@FreeBSD.org)
X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to
 glebius@FreeBSD.org using -f
Date: Mon, 15 Oct 2012 18:36:58 +0400
From: Gleb Smirnoff <glebius@FreeBSD.org>
To: John Baldwin <jhb@FreeBSD.org>
Subject: Re: svn commit: r241546 - head/sys/contrib/ipfilter/netinet
Message-ID: <20121015143658.GU89655@FreeBSD.org>
References: <201210141503.q9EF37rE087018@svn.freebsd.org>
 <201210150834.09553.jhb@freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <201210150834.09553.jhb@freebsd.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
 src-committers@FreeBSD.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 15 Oct 2012 14:37:07 -0000

On Mon, Oct 15, 2012 at 08:34:09AM -0400, John Baldwin wrote:
J> On Sunday, October 14, 2012 11:03:07 am Gleb Smirnoff wrote:
J> > Author: glebius
J> > Date: Sun Oct 14 15:03:06 2012
J> > New Revision: 241546
J> > URL: http://svn.freebsd.org/changeset/base/241546
J> > 
J> > Log:
J> >   Fix defines in r241245. We actually don't define FreeBSD.
J> >   
J> >   Reported & tested by:	Oleg Ginzburg
J> 
J> Seems like it should be using 'defined(__FreeBSD_version)' instead?

AFAIU, the construction which left after r241546 works fine. Anything
undefined resolves to zero, so in case of non-FreeBSD build we test
if (0 > 10000019) and this fails which is what we expect.

I have used this construction several times already without any side effects.
I have also seen it in some software in ports, where it works okay, too.

-- 
Totus tuus, Glebius.