Date: Mon, 15 Oct 2012 18:36:58 +0400 From: Gleb Smirnoff <glebius@FreeBSD.org> To: John Baldwin <jhb@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r241546 - head/sys/contrib/ipfilter/netinet Message-ID: <20121015143658.GU89655@FreeBSD.org> In-Reply-To: <201210150834.09553.jhb@freebsd.org> References: <201210141503.q9EF37rE087018@svn.freebsd.org> <201210150834.09553.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Oct 15, 2012 at 08:34:09AM -0400, John Baldwin wrote: J> On Sunday, October 14, 2012 11:03:07 am Gleb Smirnoff wrote: J> > Author: glebius J> > Date: Sun Oct 14 15:03:06 2012 J> > New Revision: 241546 J> > URL: http://svn.freebsd.org/changeset/base/241546 J> > J> > Log: J> > Fix defines in r241245. We actually don't define FreeBSD. J> > J> > Reported & tested by: Oleg Ginzburg J> J> Seems like it should be using 'defined(__FreeBSD_version)' instead? AFAIU, the construction which left after r241546 works fine. Anything undefined resolves to zero, so in case of non-FreeBSD build we test if (0 > 10000019) and this fails which is what we expect. I have used this construction several times already without any side effects. I have also seen it in some software in ports, where it works okay, too. -- Totus tuus, Glebius.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121015143658.GU89655>