From owner-dev-commits-src-main@freebsd.org Tue Jun 1 00:48:33 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4F4EB63478E; Tue, 1 Jun 2021 00:48:33 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qk1-x730.google.com (mail-qk1-x730.google.com [IPv6:2607:f8b0:4864:20::730]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FvD6n1L4rz3jTG; Tue, 1 Jun 2021 00:48:33 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-qk1-x730.google.com with SMTP id p66so3400020qke.7; Mon, 31 May 2021 17:48:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=rWN5iB5b03+uaC0IU9JFGh/Ub4GhNP3ZTAzA9Gi6oT4=; b=Cc8d2N93Q6LxvitEH0cL0xkCuIfChQUNEdD+JJlZyGE05tjTWn4pmzh99QbQt+IwU6 8QkKSAGDS6LuhwT+pfN6ie9CnZwGuKaSQa1111v0CiDtb22s3RGTMj6qqF+InfRDsTlv BWAb8+lp6bQ2XR2rw52jeQbbQv2MnT8d1wrj1jVDOs5pgY2TLIyXvizxYyJQT07W1miT RMTkktMEDe1mupG0q5sTiszwtKQyfQjcNey7lygtRLvm8OcOtMmWpIacIBGi69yBPGwC R3/mKySjLhIXRM94vQ/w23cGE5US+/tVtyCjaL9KJSVmHkUcXxhEVDD9Mq91VEoUzDB6 bBWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=rWN5iB5b03+uaC0IU9JFGh/Ub4GhNP3ZTAzA9Gi6oT4=; b=fs+C2SQhX3jsdJkRL9otEJjRV9NfRi3Rhl6BMDnaHj9R4lfhuts/6ybQVbkBbEiWZa /qB/blRPS/CB3mDl1YHh2ctaBp3nDkYToahi6JeBTpoxI4PhYhXzbQmHSa0PDJ3uX8Jk CLJFeuoiuoRop2qFnkifz5bdAy2p3eS6aRxEJtCcooakYyWxxYBRbMIDCK8VBF82b6DE lQ3Z8duaU8y/tYnnqSvA3F3NCuPVuTcYVTQaCFLT4YNWsBMb5KONLSTMlftDBPzlI8/I a+sU2gnCeMfoEziPx+pnmTGXzzRtbYJjKhK2+h8+TZBmJbd1+fOzzcYW24dxRNAcfwie h22g== X-Gm-Message-State: AOAM531FY5C76MoNyMD/XpNi6xz0YDALo6dnKLEQzeAZC7die7C1x8oZ okGHPJkQlTnn2Xi6dYJk9jshdyLL0f4= X-Google-Smtp-Source: ABdhPJwjei0CnYr0DR3RFyHIz2Us4EnoF2c4N0m3s6HBth+7P7ncpDYUiF4WrU+0TGevCnQWqziO8A== X-Received: by 2002:a37:45c3:: with SMTP id s186mr18825202qka.318.1622508511957; Mon, 31 May 2021 17:48:31 -0700 (PDT) Received: from nuc ([142.126.172.178]) by smtp.gmail.com with ESMTPSA id f15sm9484300qtg.25.2021.05.31.17.48.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 May 2021 17:48:31 -0700 (PDT) Sender: Mark Johnston Date: Mon, 31 May 2021 20:48:32 -0400 From: Mark Johnston To: Jessica Clarke Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Subject: Re: git: 18f55c67f746 - main - x86: Fix lapic_ipi_alloc() on i386 Message-ID: References: <202105312309.14VN9nWf040168@gitrepo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 4FvD6n1L4rz3jTG X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Jun 2021 00:48:33 -0000 On Tue, Jun 01, 2021 at 12:48:52AM +0100, Jessica Clarke wrote: > On 1 Jun 2021, at 00:09, Mark Johnston wrote: > > > > The branch main has been updated by markj: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=18f55c67f746f0ad12fe972328234d340a621df9 > > > > commit 18f55c67f746f0ad12fe972328234d340a621df9 > > Author: Mark Johnston > > AuthorDate: 2021-05-31 22:51:14 +0000 > > Commit: Mark Johnston > > CommitDate: 2021-05-31 22:51:14 +0000 > > > > x86: Fix lapic_ipi_alloc() on i386 > > > > The loop which checks to see if "dynamic" IDT entries are allocated > > needs to compare with the trampoline address of the reserved ISR. > > Otherwise it will never succeed. > > > > Reported by: Harry Schmalzbauer > > Tested by: Harry Schmalzbauer > > Reviewed by: kib > > MFC after: 1 week > > Sponsored by: The FreeBSD Foundation > > Differential Revision: https://reviews.freebsd.org/D30576 > > --- > > sys/x86/x86/local_apic.c | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/sys/x86/x86/local_apic.c b/sys/x86/x86/local_apic.c > > index 5b4910d4b891..bb575d0c601d 100644 > > --- a/sys/x86/x86/local_apic.c > > +++ b/sys/x86/x86/local_apic.c > > @@ -2127,6 +2127,10 @@ native_lapic_ipi_vectored(u_int vector, int dest) > > > > #endif /* SMP */ > > > > +#ifdef __i386__ > > +extern uintptr_t setidt_disp; > > uintptr_t here is fishy. Should it not be size_t or ptrdiff_t? Yes, either of those seems more correct. See https://reviews.freebsd.org/D30590