From nobody Sun Jul 12 17:19:10 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gysk85PHyz6kQrc; Sun, 12 Jul 2026 17:19:12 +0000 (UTC) (envelope-from kevans@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gysk84Rh9z3SgZ; Sun, 12 Jul 2026 17:19:12 +0000 (UTC) (envelope-from kevans@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1783876752; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=W0vYDtJzdZ6vhlXP9klmvfX4fnmcYgqdjJyvJmxvit8=; b=vXWDqnHB3vo1kq89pPlnykeVko8EDOu4tqE5DvAvUCeIyZZdgKGWIUFTP5KeDnAlCM3mvr /GJBhstOwQwAKFypM8vzgjxobGZ50nNs7hozIgxCGfNXMC5apVqcwXS4IXCu1ryBE9DsGf qy0jYTm7yQvP0Yapmhbgkg/NAuX7s0OKpURWzkpLUPl5Rqn7SBbYe2Ajouy0zB3H9DyMoh hiCLfSSy8uWE/53O/s28xejlZ788lPwEnvYSg+E55n0JKhoDf7r5YVQRukiOydaDNPKFUj cAP2yrIEyCoHVCOQB6h8IiyyQOQz+0jY/Y1SwWGR0qHDSzzVLpdRSxLi9wY/tw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1783876752; a=rsa-sha256; cv=none; b=PmNUmvCSuN89r6vLLK+dUs9G44TCJ5WYwNnkJIbonSafu/pyDt0od1YbmxEySdo3RhQbEu wy24DKI9WmTQh92I/nrIEyuv5a8txOUaT+geUS5Cy9LdR4eo/ZnrPzAMit0Q3QaZM1SZnh dUzdC2qqPT6pVoCe+ny2rz0+YA29TzJnMqU9Aa9Icp0p/T7rhFxSVrFmBX5M2SxJAOrQX8 QcyJCGddmv8SPr1oOtyN+2Xdbp+tDMwIAq5ka9uJtQhldSQMiEJgUeaonCN0q6gbKQxA40 UkhLvwT6UTv+VOFHDjkjc6kNAZXuhjTch7u/GNW82c6hCGGuq2orEoSV5UlkrQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1783876752; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=W0vYDtJzdZ6vhlXP9klmvfX4fnmcYgqdjJyvJmxvit8=; b=UCiHB0YCBW2SJZY19ftYqweD7pL179sew0iUHdLOjF+445EZrlzoz4RNWUtOj/A+sCJmpH ekln+Vc9iopgp/HDwmCpuUc0q+i4BQx8Z/ytQxNq7vIr92e9rsT0Pa73ZGNErEgchc5zb5 IKPUHTSZYW2KJNcvQw51SdEGwu8jYCO5uowlzShK1DlxJv1g0aJ+gdN5soT7BF0R3eRnAy 9GF1NR2CGOYF+BJIwhsEPLSWHxnYN1Bq9WfHJIBnC2uvs0UvyiLryegqcVNoMYcI2LBg8k Cp6xG80+HasvB86mlAFvchl+Oi977Lh/6fNWY0TFe967qy5rWRww0NOE0XkWMw== Received: from [10.9.4.95] (unknown [209.182.120.176]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: kevans/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4gysk76s3Dz19CX; Sun, 12 Jul 2026 17:19:11 +0000 (UTC) (envelope-from kevans@FreeBSD.org) Message-ID: <07894a56-cdfb-40dc-8746-60eaf596e4c4@FreeBSD.org> Date: Sun, 12 Jul 2026 12:19:10 -0500 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 28d85db46b48 - main - xhci: Do not drop and add bits in xhci To: Adrian Chadd Cc: ShengYi Hung , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, Vladimir Kondratyev References: <6a1008a0.3f79c.1d455f29@gitrepo.freebsd.org> <49761290-2d6c-403f-acdd-48b5b536804c@FreeBSD.org> Content-Language: en-US From: Kyle Evans In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/12/26 10:43, Adrian Chadd wrote: > On Sat, 11 Jul 2026 at 20:21, Kyle Evans wrote: >> >> On 5/22/26 02:41, ShengYi Hung wrote: >>> The branch main has been updated by aokblast: >>> >>> URL: https://cgit.FreeBSD.org/src/commit/?id=28d85db46b484589e2ee74cf4b270db066821de1 > >> Hi, >> >> This patch reliably fixes a bug I've been trying to track down in a u2f(4) patch >> that I've been testing, and I'm wondering if you can help connect the dots. I >> have a Solo2 u2f(4) key that I find will inconsistently desync (for other reasons) >> and hang, and the solution for *that* is to release this NOT_YET block[0] in >> u2f_dtor(). >> >> The problem I was hunting down is that doing so subsequently broke my Yubikey in a >> way that this patch alone seems to fix. It would hang on every other ssh attempt, as >> long as we issued usbd_transfer_stop on our interrupt endpoints upon last-close. It >> was known to work with uhid(4) reliably which issues a stop as well, and that's the >> thing I can't really explain. Is there something that uhid(4) / usb_dev.c is doing >> that might have accidentally worked around this? >> >> This was the only commit that looked relevant in the fast-forward I did for my latest >> round of testing from 9c18d55a768a3 to 707ee7ff952c5, and reverting just this patch >> reliably re-introduces the problem I was having with the Yubikey. >> > > My guess is the yubikey device firmware pays attention to this bit and > the state is > only reset when the state cycles through STOP. If you're curious, try > comparing usbdump > captures before/after the fix and look for explicit differences in > things and then > guess what the firmware is doing. > Solid suggestion, thanks- I forgot that usbdump is even a thing, so I'll play with this a bit. Thanks, Kyle Evans