From owner-cvs-src@FreeBSD.ORG Wed May 24 03:05:03 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E80FB16A5F4; Wed, 24 May 2006 03:05:02 +0000 (UTC) (envelope-from iedowse@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B609043D5D; Wed, 24 May 2006 03:05:00 +0000 (GMT) (envelope-from iedowse@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4O34BJ5038585; Wed, 24 May 2006 03:04:11 GMT (envelope-from iedowse@repoman.freebsd.org) Received: (from iedowse@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4O34BKO038584; Wed, 24 May 2006 03:04:11 GMT (envelope-from iedowse) Message-Id: <200605240304.k4O34BKO038584@repoman.freebsd.org> From: Ian Dowse Date: Wed, 24 May 2006 03:04:11 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/usb ehci.c ehcivar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 May 2006 03:05:03 -0000 iedowse 2006-05-24 03:04:11 UTC FreeBSD src repository Modified files: sys/dev/usb ehci.c ehcivar.h Log: Attempt to follow the procedure described in section 4.10 of the EHCI spec for linking in new qTDs into an asynchronous QH. This requires that there is a qTD marked as not active and not halted at the start of the QH's list, and the hardware will know to re-fetch the qTD on each pass rather than just looking at the overlay qTD: "The host controller must be able to advance the queue from the Fetch QH state in order to avoid all hardware/software race conditions. This simple mechanism allows software to simply link qTDs to the queue head and activate them, then the host controller will always find them if/when they are reachable." This is achieved by keeping an "inactivesqtd" entry on the QH list, and re-using it each time as the start of the next transfer, and allocating a new qTD to become the next inactivesqtd. Then a new transfer can be activated by just setting its "active" flag, which avoids all the previous messing with overlay qTD state in ehci_set_qh_qtd(). Revision Changes Path 1.45 +223 -94 src/sys/dev/usb/ehci.c 1.14 +1 -0 src/sys/dev/usb/ehcivar.h