From owner-freebsd-arch@FreeBSD.ORG Mon Mar 10 16:20:08 2014 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id A2BC2F79 for ; Mon, 10 Mar 2014 16:20:08 +0000 (UTC) Received: from mail-pd0-f169.google.com (mail-pd0-f169.google.com [209.85.192.169]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 74AE8CF6 for ; Mon, 10 Mar 2014 16:20:08 +0000 (UTC) Received: by mail-pd0-f169.google.com with SMTP id fp1so7259589pdb.14 for ; Mon, 10 Mar 2014 09:20:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:content-type:mime-version:subject:from :in-reply-to:date:cc:content-transfer-encoding:message-id:references :to; bh=y3de8dFHuByGitLfgxttDdBSNrutbxKFQEbGTTC6OBY=; b=AqsUU0j2f9eC42+ZpbB6gVSCwbetURpQ2EhV63qIOev+nwDIrxgja39jjMtymqKla2 QfV5Inx95hEZPUkSfCCqa65i+W8fuSMD7vGZvxOMQMcPjkzvhaJOTPT1TUNZRbxYZZBJ Lg4hqQ0kFwtgXqPp6eYRHrGEval75jiSs9+ykL8yCp4fL2Xi70IHgklcw5fMryr6GFWS SNhZ6Hu6Y61GK6/GEkgAuIS6qtgH65bKkJ5a2nrywGrI+ZJOs6HsccLGAZlcZRUT3Fnq eG2q3t8VB3decbTY3VzjfmROlwmRyBTbZ6j/AqFB1Bnum4IQgYW7w5Us+sjYhwPc9s6f qA8A== X-Gm-Message-State: ALoCoQl8NKm7f/BOpwhqtuVMPE2kN6zoHYoJyPyOzBspDA+GxqlHAxR9Qook1VU6bLyzKdJ2OOlf X-Received: by 10.68.229.106 with SMTP id sp10mr41460628pbc.23.1394468404764; Mon, 10 Mar 2014 09:20:04 -0700 (PDT) Received: from [10.64.26.252] (dc1-prod.netflix.com. [69.53.236.251]) by mx.google.com with ESMTPSA id bc4sm65919122pbb.2.2014.03.10.09.20.03 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 10 Mar 2014 09:20:04 -0700 (PDT) Sender: Warner Losh Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 7.2 \(1874\)) Subject: Re: option NEW_PCIB From: Warner Losh In-Reply-To: <201403100945.20298.jhb@freebsd.org> Date: Mon, 10 Mar 2014 10:20:02 -0600 Content-Transfer-Encoding: quoted-printable Message-Id: <51AC226F-7516-48EA-BC9D-B67F6508BCBF@bsdimp.com> References: <1394200335.1149.370.camel@revolution.hippie.lan> <58AB4C66-4267-414D-80D4-B97FF86A94A5@bsdimp.com> <201403100945.20298.jhb@freebsd.org> To: John Baldwin X-Mailer: Apple Mail (2.1874) Cc: freebsd-arm , Ian Lepore , freebsd-arch X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Mar 2014 16:20:08 -0000 On Mar 10, 2014, at 7:45 AM, John Baldwin wrote: > On Friday, March 07, 2014 9:38:33 am Warner Losh wrote: >>=20 >> On Mar 7, 2014, at 6:52 AM, Ian Lepore wrote: >>=20 >>> Every architecture has "option NEW_PCIB" in its conf/DEFAULTS except = arm >>> and mips. Is that on purpose? What are the implications of adding = it? >>> Or maybe more importantly, what are the implications of it not being >>> there? >>=20 >> This is John Baldwin=92s option for his reworked PCI bridge code. He = did that as >> a fallback in case he really messed up something. It introduces = renumbering >> of busses that don=92t already have numbers assigned. It should be = enabled on >> ARM, but the required resource isn=92t defined on arm, and some of = the other >> required glue doesn=92t seem to be implemented for arm yet, which is = why things >> are the way they are at the moment. I think John intends for the = option to go >> away, and everything it covers will be =91standard=92. >=20 > Yes. I just added a page on the wiki about NEW_PCIB explaining the = changes > each platform needs for it in a bit more detail on Friday: >=20 > https://wiki.freebsd.org/NEW_PCIB >=20 > I have posted patches in the past to arm@ to handle step 2 in the = NEW_PCIB > base requirements for arm@ but haven't been able to get folks to test = them. > I just recently made a new pass through sys/arm in a p4 tree to = refresh this. > I haven't even compiled these yet, but you can find the patch here: >=20 > http://people.freebsd.org/~jhb/patches/arm_activate2.patch I=92ll take a look=85 Thanks for putting these together... > I don't know how best to think about fixing i80321_pci to work with = NEW_PCIB. > It has some hack that I don't fully understand. I think it uses an > alternate mapping of the same resource range to use a different base = address > for the mapping. Longer term I think the bus_map_resource() think I = suggest > at the bottom is how to handle that, but even then there would still = need to > be a way to know which base address a given resource wanted to use. = It may > be that we need to implement that differently (bus-specific rman = flag?) While I=92m not normally a big fan of retiring code, I think in this = case it may be easier to just retire the i80321 support. It is really old, released in 2002. = There=92s not too many boards that had this on it, and I think all the ones that ever ran = FreeBSD are in cognet@=91s lab. On the whole, it is yet another machine to update that slows down = any modernization processes we have... Warner