From owner-freebsd-x11@FreeBSD.ORG Sat Oct 4 18:19:25 2008 Return-Path: Delivered-To: freebsd-x11@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C114F1065687 for ; Sat, 4 Oct 2008 18:19:25 +0000 (UTC) (envelope-from onemda@gmail.com) Received: from rv-out-0506.google.com (rv-out-0506.google.com [209.85.198.239]) by mx1.freebsd.org (Postfix) with ESMTP id 93F468FC08 for ; Sat, 4 Oct 2008 18:19:25 +0000 (UTC) (envelope-from onemda@gmail.com) Received: by rv-out-0506.google.com with SMTP id b25so1936733rvf.43 for ; Sat, 04 Oct 2008 11:19:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=Lii8cNQHuFHv8lwzLTmHM3lW3VIKApY1vOddvwnyRTg=; b=ZTxQ6+abHMlS3ty/dd9j5nn1+crW0PEf/nKVQNUnMaWiRATccfsQ3JO8tvrnE83Dnu t6m0K/7YQJekWkbulfmS7egBj6QCtkX450ESNQ12WoEXgkhYnkcomhc+CrwK/JFqa8Fl fg9aRerKIUYJGSkXWQsT3c/ARZ6bW50K8PCCo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=IqUJljoqDmWAjqiLHzEJ2V8z+408ZcO3x4v0oHaV+uSG84n5QZzPTrBCDlu5Ga1Saz bFbvrGktLH5npjWr3Y4vWzl/ucUw0mXvEmWHi7/CxTZ2GeWALm0gnKoDcWTQWLbfduPi Lrzn/42eWs1W0L8UeWfbg1bklungKQhhVRnNI= Received: by 10.140.125.4 with SMTP id x4mr1557474rvc.229.1223144362068; Sat, 04 Oct 2008 11:19:22 -0700 (PDT) Received: by 10.141.189.15 with HTTP; Sat, 4 Oct 2008 11:19:22 -0700 (PDT) Message-ID: <3a142e750810041119wc63cdf7u85149c88c5182696@mail.gmail.com> Date: Sat, 4 Oct 2008 20:19:22 +0200 From: "Paul B. Mahol" To: "Robert Noland" In-Reply-To: <1223138743.1619.35.camel@wombat.2hip.net> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <1223134762.1619.32.camel@wombat.2hip.net> <1223138743.1619.35.camel@wombat.2hip.net> Cc: freebsd-x11 Subject: Re: drm MSI support X-BeenThere: freebsd-x11@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: X11 on FreeBSD -- maintaining and support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Oct 2008 18:19:25 -0000 On 10/4/08, Robert Noland wrote: > On Sat, 2008-10-04 at 11:39 -0400, Robert Noland wrote: >> I would like to get some initial feedback on this patch. It enables MSI >> on capable cards. (I'm using it on my i965gm) The guys at Intel have >> done this in the Linux driver. I have implemented it in our >> infrastructure code which means that we will enable it on any hardware >> that reports capable. The Intel guys have explicitly blacklisted a >> couple of 945 class devices, stating that they report capable but don't >> appear to work. While I would like to get verification that these chips >> don't work, don't be surprised if it doesn't work if you have chips 2772 >> or 27a2. I have not implemented the blacklist bits yet. >> >> The Linux crew has never enabled MSI on radeon hardware, though several >> devices appear to report capable. When I inquired as to why they hadn't >> done so, they just stated that they hadn't gotten around to it. I'm >> particularly interested to see how this works on radeons. >> >> In order to use this patch, you need to be running CURRENT as I had to >> make a few other changes to vgapci to get this working. You can see if >> you hardware is capable by running pciconf -lvc. You will see something >> like this: > > CURRENT needs to be at least: > r183194 | rnoland | 2008-09-19 15:11:35 -0400 (Fri, 19 Sep 2008) | 6 > lines > > pci_setup_intr() will only enable MSI/MSI-X for direct children. Add > methods > to vga_pci.c to request on behalf of it's children. This causes vgapci > to show > up as the interrupt owner in vmstat -i, rather than the child device. > > Approved by: jhb(mentor) > > robert. > >> vgapci0@pci0:0:2:0: class=0x030000 card=0x01f91028 chip=0x2a028086 >> rev=0x0c hdr=0x00 >> vendor = 'Intel Corporation' >> device = 'Mobile 965 Express Integrated Graphics Controller' >> class = display >> subclass = VGA >> cap 05[90] = MSI supports 1 message >> cap 01[d0] = powerspec 3 supports D0 D3 current D0 >> >> When drm loads it will also report that it has enabled MSI. >> >> Please send me reports of what chips do/don't work. vgapci0@pci0:0:2:0: class=0x030000 card=0x30a2103c chip=0x27a28086 rev=0x03 hdr=0x00 vendor = 'Intel Corporation' device = 'Mobile 945GM/GU Express Integrated Graphics Controller' class = display subclass = VGA cap 05[90] = MSI supports 1 message cap 01[d0] = powerspec 2 supports D0 D3 current D0 drm0: on vgapci0 info: [drm] MSI enabled 1 message(s) vgapci0: child drm0 requested pci_enable_busmaster info: [drm] AGP at 0xe0000000 256MB info: [drm] Initialized i915 1.6.0 20080730 drm0: [ITHREAD] vgapci0: child drm0 requested pci_disable_busmaster info: [drm] MSI released drm0: detached It decrease framerate of glxgears 10x. stellarium performance is even worse (worse than using software rendering when DRI is disabled).