From owner-freebsd-ports-bugs@FreeBSD.ORG Sat Jul 29 14:50:11 2006 Return-Path: X-Original-To: freebsd-ports-bugs@hub.freebsd.org Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C674A16A4DD for ; Sat, 29 Jul 2006 14:50:11 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3688443D49 for ; Sat, 29 Jul 2006 14:50:11 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k6TEoA6e006196 for ; Sat, 29 Jul 2006 14:50:10 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k6TEoAkn006192; Sat, 29 Jul 2006 14:50:10 GMT (envelope-from gnats) Resent-Date: Sat, 29 Jul 2006 14:50:10 GMT Resent-Message-Id: <200607291450.k6TEoAkn006192@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Yoshisato YANAGISAWA Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 791B516A4DA for ; Sat, 29 Jul 2006 14:44:45 +0000 (UTC) (envelope-from yanagisawa@frodo.csg.is.titech.ac.jp) Received: from frodo.csg.is.titech.ac.jp (frodo.csg.is.titech.ac.jp [131.112.40.165]) by mx1.FreeBSD.org (Postfix) with ESMTP id 80AA643D70 for ; Sat, 29 Jul 2006 14:44:42 +0000 (GMT) (envelope-from yanagisawa@frodo.csg.is.titech.ac.jp) Received: from frodo.csg.is.titech.ac.jp (localhost [127.0.0.1]) by frodo.csg.is.titech.ac.jp (8.13.6/8.13.6) with ESMTP id k6TEic7N014118 for ; Sat, 29 Jul 2006 23:44:38 +0900 (JST) (envelope-from yanagisawa@frodo.csg.is.titech.ac.jp) Received: (from yanagisawa@localhost) by frodo.csg.is.titech.ac.jp (8.13.6/8.13.6/Submit) id k6TEiclS014117; Sat, 29 Jul 2006 23:44:38 +0900 (JST) (envelope-from yanagisawa) Message-Id: <200607291444.k6TEiclS014117@frodo.csg.is.titech.ac.jp> Date: Sat, 29 Jul 2006 23:44:38 +0900 (JST) From: Yoshisato YANAGISAWA To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: ports/101024: Maintainer Update: mail/dkimproxy rc.d scripts will log messages X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Yoshisato YANAGISAWA List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 29 Jul 2006 14:50:11 -0000 >Number: 101024 >Category: ports >Synopsis: Maintainer Update: mail/dkimproxy rc.d scripts will log messages >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: maintainer-update >Submitter-Id: current-users >Arrival-Date: Sat Jul 29 14:50:10 GMT 2006 >Closed-Date: >Last-Modified: >Originator: Yoshisato YANAGISAWA >Release: FreeBSD 6.1-RELEASE-p1 i386 >Organization: Tokyo Institute of Technology. >Environment: System: FreeBSD frodo.csg.is.titech.ac.jp 6.1-RELEASE-p1 FreeBSD 6.1-RELEASE-p1 #90: Fri Jun 2 20:33:54 JST 2006 yanagisawa@frodo.csg.is.titech.ac.jp:/usr/obj/usr/src/sys/FRODO i386 >Description: rc.d scripts are changed: - to log all messages at start-up time of a daemon, - to show error messages when some error occurs at that time, - and to checks $dkfilter_{in,out}_user exist or not. >How-To-Repeat: n/a >Fix: Use following patch to apply changes. diff -ruN dkimproxy.bak/files/dkimproxy_in.in dkimproxy/files/dkimproxy_in.in --- dkimproxy.bak/files/dkimproxy_in.in Sat Jul 29 23:31:47 2006 +++ dkimproxy/files/dkimproxy_in.in Sat Jul 29 23:26:24 2006 @@ -34,11 +34,27 @@ echo "${name} already running?" exit 1 fi + if pw user show "${dkimproxy_in_user}" > /dev/null 2>&1; then else + echo "dkimproxy_in_user: ${dkimproxy_in_user} not found" + exit 1 + fi + echo "Starting ${name}" + logger -t ${name} "Starting ${name}" touch ${dkimproxy_in_pidfile} chown ${dkimproxy_in_user} ${dkimproxy_in_pidfile} - su -m ${dkimproxy_in_user} -c "daemon -cf -p ${dkimproxy_in_pidfile} \ - %%PREFIX%%/bin/dkimproxy.in ${dkimproxy_in_flags}" - echo "Starting ${name}" + logfile=`mktemp /tmp/${name}.XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX` + su -m ${dkimproxy_in_user} -c "daemon -c -p ${dkimproxy_in_pidfile} \ + %%PREFIX%%/bin/dkimproxy.in ${dkimproxy_in_flags}" \ + > /dev/null 2> ${logfile} + sleep 1 # XXX: wait until dkimproxy start. + logger -t ${name} "`cat ${logfile}`" + err=`grep Error ${logfile}` + if [ "${err}" ]; then + echo "Failed to start ${name}." + echo "${err}" + rm -f ${dkimproxy_in_pidfile} + fi + rm -f ${logfile} } dkimproxy_in_stop() @@ -47,9 +63,10 @@ echo "${name} not running?" exit 1 fi + echo "Stopping ${name}" + logger -t ${name} "Stopping ${name}" kill `cat ${dkimproxy_in_pidfile}` rm -f ${dkimproxy_in_pidfile} - echo "Stopping ${name}" } load_rc_config $name diff -ruN dkimproxy.bak/files/dkimproxy_out.in dkimproxy/files/dkimproxy_out.in --- dkimproxy.bak/files/dkimproxy_out.in Sat Jul 29 23:31:47 2006 +++ dkimproxy/files/dkimproxy_out.in Sat Jul 29 23:26:32 2006 @@ -13,7 +13,7 @@ # dkimproxy_out_enable="YES" # # Before you enable dkimproxy.out, you also need to make your domainkey to -# set it to DNS and configurate dkimproxy_flags. +# set it to DNS and configurate dkimproxy_out_flags. # . %%RC_SUBR%% @@ -39,11 +39,27 @@ echo "${name} already running?" exit 1 fi + if pw user show "${dkimproxy_out_user}" > /dev/null 2>&1; then else + echo "dkimproxy_out_user: ${dkimproxy_out_user} not found" + exit 1 + fi + echo "Starting ${name}" + logger -t ${name} "Starting ${name}" touch ${dkimproxy_out_pidfile} chown ${dkimproxy_out_user} ${dkimproxy_out_pidfile} - su -m ${dkimproxy_out_user} -c "daemon -cf -p ${dkimproxy_out_pidfile} \ - %%PREFIX%%/bin/dkimproxy.out ${dkimproxy_out_flags}" - echo "Starting ${name}." + logfile=`mktemp /tmp/${name}.XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX` + su -m ${dkimproxy_out_user} -c "daemon -c -p ${dkimproxy_out_pidfile} \ + %%PREFIX%%/bin/dkimproxy.out ${dkimproxy_out_flags}" \ + > /dev/null 2> ${logfile} + sleep 1 # XXX: wait until dkimproxy start. + logger -t ${name} "`cat ${logfile}`" + err=`grep Error ${logfile}` + if [ "${err}" ]; then + echo "Failed to start ${name}." + echo "${err}" + rm -f ${dkimproxy_out_pidfile} + fi + rm -f ${logfile} } dkimproxy_out_stop() @@ -52,9 +68,10 @@ echo "${name} not running?" exit 1 fi + echo "Stopping ${name}" + logger -t ${name} "Stopping ${name}" kill `cat ${dkimproxy_out_pidfile}` rm -f ${dkimproxy_out_pidfile} - echo "Stopping ${name}" } load_rc_config $name >Release-Note: >Audit-Trail: >Unformatted: