Date: Mon, 16 Mar 2015 12:36:44 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 198045] Build tools hiding dependency issues Message-ID: <bug-198045-13-lBy85WsN8m@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-198045-13@https.bugs.freebsd.org/bugzilla/> References: <bug-198045-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=198045 --- Comment #2 from melvyn@magemana.nl --- Hi Brian, I didn't say they make new dependencies. The root cause of at least 1 and 3 and I suspect 2 as well, is that the leaf port's make doesn't re-evaluate a set value when it comes back from visiting it's children. By closing the leaf port's make and executing the dependency builds in their own make process, these bugs are not exposed by the existing tools. Here's the fix for pango: diff --git a/x11-toolkits/pango/Makefile b/x11-toolkits/pango/Makefile index 5a54d96..ce1b839e 100644 --- a/x11-toolkits/pango/Makefile +++ b/x11-toolkits/pango/Makefile @@ -54,10 +54,10 @@ PLIST_SUB+= X11="@comment " .endif pre-configure: -.if !exists(${LOCALBASE}/libdata/pkgconfig/cairo-gobject.pc) - @${ECHO_CMD} "${PKGNAME}: Needs cairo with GLIB (GObject) support enabled." - @${FALSE} -.endif + @if [ ! -f${LOCALBASE}/libdata/pkgconfig/cairo-gobject.pc ]; then \ + ${ECHO_CMD} "${PKGNAME}: Needs cairo with GLIB (GObject) support enabled."; \ + ${FALSE}; \ + fi .include <bsd.port.mk> -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-198045-13-lBy85WsN8m>