From owner-freebsd-ports-bugs@FreeBSD.ORG  Mon Mar 16 12:36:44 2015
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
Delivered-To: freebsd-ports-bugs@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 97CF678F
 for <freebsd-ports-bugs@FreeBSD.org>; Mon, 16 Mar 2015 12:36:44 +0000 (UTC)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 7E3C1901
 for <freebsd-ports-bugs@FreeBSD.org>; Mon, 16 Mar 2015 12:36:44 +0000 (UTC)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t2GCai5u045987
 for <freebsd-ports-bugs@FreeBSD.org>; Mon, 16 Mar 2015 12:36:44 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-ports-bugs@FreeBSD.org
Subject: [Bug 198045] Build tools hiding dependency issues
Date: Mon, 16 Mar 2015 12:36:44 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Ports & Packages
X-Bugzilla-Component: Ports Framework
X-Bugzilla-Version: Latest
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: Affects Only Me
X-Bugzilla-Who: melvyn@magemana.nl
X-Bugzilla-Status: New
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-198045-13-lBy85WsN8m@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-198045-13@https.bugs.freebsd.org/bugzilla/>
References: <bug-198045-13@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs/>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Mar 2015 12:36:44 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=198045

--- Comment #2 from melvyn@magemana.nl ---
Hi Brian,

I didn't say they make new dependencies. The root cause of at least 1 and 3 and
I suspect 2 as well, is that the leaf port's make doesn't re-evaluate a set
value when it comes back from visiting it's children.
By closing the leaf port's make and executing the dependency builds in their
own make process, these bugs are not exposed by the existing tools.

Here's the fix for pango:

diff --git a/x11-toolkits/pango/Makefile b/x11-toolkits/pango/Makefile
index 5a54d96..ce1b839e 100644
--- a/x11-toolkits/pango/Makefile
+++ b/x11-toolkits/pango/Makefile
@@ -54,10 +54,10 @@ PLIST_SUB+= X11="@comment "
 .endif

 pre-configure:
-.if !exists(${LOCALBASE}/libdata/pkgconfig/cairo-gobject.pc)
-       @${ECHO_CMD} "${PKGNAME}: Needs cairo with GLIB (GObject) support
enabled."
-       @${FALSE}
-.endif
+       @if [ ! -f${LOCALBASE}/libdata/pkgconfig/cairo-gobject.pc ]; then \
+               ${ECHO_CMD} "${PKGNAME}: Needs cairo with GLIB (GObject)
support enabled."; \
+               ${FALSE}; \
+       fi

 .include <bsd.port.mk>

-- 
You are receiving this mail because:
You are the assignee for the bug.