From owner-freebsd-stable@FreeBSD.ORG Fri Aug 3 16:49:42 2012 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DAADE1065673 for ; Fri, 3 Aug 2012 16:49:42 +0000 (UTC) (envelope-from jim.harris@gmail.com) Received: from mail-wi0-f178.google.com (mail-wi0-f178.google.com [209.85.212.178]) by mx1.freebsd.org (Postfix) with ESMTP id 687718FC19 for ; Fri, 3 Aug 2012 16:49:41 +0000 (UTC) Received: by wibhr14 with SMTP id hr14so652791wib.13 for ; Fri, 03 Aug 2012 09:49:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=oIo2j3I1/bjCEVZyT8GeAgR48ckA60ZXvNLdl28T7f4=; b=B5PLoC7uJWfCDrLtD8WmoU2bpK5LlkLjObZ5CGVLZJ5L9ZU+gHV3SZtPslk35Ru6sw BWDoOF/vtnKVxKDUKlDH0JXkjBA5Y75s3dwNk33g4WSehfNfSr71vY6KHm8uiQtwEKaT r8/rT5iQVLyZIOY2f5hpYGFbHpG2dBinO/tO6ftQJjblcB8WvO2y8jMJrWUaQ8N5bPaQ H9dcUO7+YFJBtz0A5+BV0QPjM6l+KR2OI7UzhYoV+8llV/STf7Qj/mpPeulv/a43XiMq o0lpqr1bXdejEyGVv0Y/DKm0tVqG46lg3bHDYBLydywt5il3WjmQw81IdMMBceUsHEbk k4Qg== MIME-Version: 1.0 Received: by 10.180.98.200 with SMTP id ek8mr5784391wib.0.1344012581066; Fri, 03 Aug 2012 09:49:41 -0700 (PDT) Sender: jim.harris@gmail.com Received: by 10.216.241.203 with HTTP; Fri, 3 Aug 2012 09:49:41 -0700 (PDT) In-Reply-To: <501BBEBB.5010106@bsdinfo.com.br> References: <1977769407.20120322151934@tkachuk.name> <4F6B4030.5090907@FreeBSD.org> <4F6B4631.8020006@gmail.com> <4F6B4B93.7020309@FreeBSD.org> <4F6B4FAB.1020202@gmail.com> <1332434072.8403.79.camel@revolution.hippie.lan> <501B8004.1000503@ateamsystems.com> <501BBEBB.5010106@bsdinfo.com.br> Date: Fri, 3 Aug 2012 09:49:41 -0700 X-Google-Sender-Auth: oYi6OF4hVqv9C7rF7vHxWMR6KKc Message-ID: From: Jim Harris To: Marcelo Gondim Content-Type: text/plain; charset=ISO-8859-1 Cc: freebsd-stable@freebsd.org Subject: Re: geom_virstor with kernel panic in FreeBSD 9.x X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Aug 2012 16:49:42 -0000 On Fri, Aug 3, 2012 at 5:06 AM, Marcelo Gondim wrote: > Hi all, > > I sent a PR [1] but I decided to also send the problem here. > If you try to destroy a geom_virstor that does not exist, this causes a > kernel panic immediately. > > Just try: > > gvirstor load > gvirstor destroy tatata > > # uname -a > FreeBSD zeus.xxxx.xxx.br 9.1-PRERELEASE FreeBSD 9.1-PRERELEASE #27: Mon Jul > 16 01:41:24 BRT 2012 root@zeus.xxxx.xxx.br:/usr/obj/usr/src/sys/GONDIM > amd64 > > [1] http://www.freebsd.org/cgi/query-pr.cgi?pr=170199 > > Best regards, > Gondim > Hi Gondim, Can you test the following patch? Index: sys/geom/virstor/g_virstor.c =================================================================== --- sys/geom/virstor/g_virstor.c (revision 238909) +++ sys/geom/virstor/g_virstor.c (working copy) @@ -235,6 +235,12 @@ return; } sc = virstor_find_geom(cp, name); + if (sc == NULL) { + gctl_error(req, "Don't know anything about '%s'", name); + g_topology_unlock(); + return; + } + LOG_MSG(LVL_INFO, "Stopping %s by the userland command", sc->geom->name); update_metadata(sc); Thanks, -Jim > > > _______________________________________________ > freebsd-stable@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-stable > To unsubscribe, send any mail to "freebsd-stable-unsubscribe@freebsd.org"