From owner-svn-src-all@freebsd.org Fri Jan 22 07:05:59 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 226E5A8DC59; Fri, 22 Jan 2016 07:05:59 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf0-x229.google.com (mail-pf0-x229.google.com [IPv6:2607:f8b0:400e:c00::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E9C021DD7; Fri, 22 Jan 2016 07:05:58 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pf0-x229.google.com with SMTP id 65so37260579pff.2; Thu, 21 Jan 2016 23:05:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=e10w6g0lEHnkJ/T4YRvCJXTp5KStQj30KOoU7KvR5Yg=; b=tD/BWXEID0yg2xLpOmMUZ4RB0rPlfqueXI382DEl4Rx2Zc01DhqYfkjLI+7DpkSVWH lGqknQp5Dg7vsMjRtY39MTfYu+EbYpbMrf5jb69eWiRTWroa3SnEbJx+B2nb5JvGggxB XQCh3LF1qIg4iUT5fjjyubtOcQJwfyyvRGJxAGZErUhSW0PStUqpWYBVhacBTBterDfi EFsNP7WWk5BH2KMPHLI4MHk84n/8X3LCbzkUeVv1YhlpUpTltvHFfqZkT70mHXI1BRif Hzf5izs416D9tLXIyG06HHUektyZor3cfx1SVOEM4QBeWX3BcaTzMoZO9w9ldLV6uhjS VUjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:content-type:mime-version:subject:from :in-reply-to:date:cc:content-transfer-encoding:message-id:references :to; bh=e10w6g0lEHnkJ/T4YRvCJXTp5KStQj30KOoU7KvR5Yg=; b=BcuDxug+nNCemKtrx+WWaO1oebnqhunmbfd7lGI9YFwxiZOxrE88yMCctsV0bUh8j9 foxhqOsBDcyYoS7q87nBQzfSg+9xcP0iaXLa2dJE1YLwXa+4SrQnJwO6Y1WyyutqOBtV ASD4dd4xkaVqwC+uPHu46vcNd74FHTF4GuaM0/s4NnQkuDWspKHXwnbwfO1JzjY+X3Hz 18gVFuKHU3OznAOeJODGtMa+pp+SNQA7BjAP+92SI0ySM80UGB8OirImJN7giTLRGnHj /SWIRu41uFrpf7W53UJYhLc0jJ+8YZVjtQg7VZBHRtqXouEQVHpFCProIGQb892iEth9 UaBg== X-Gm-Message-State: AG10YORM9WNUpTGPKY4IrsWleoHiL1Gext+IcPNGc45LGW4apyn1CnVlW0BgiUaId6qgyA== X-Received: by 10.98.17.79 with SMTP id z76mr2260906pfi.16.1453446358539; Thu, 21 Jan 2016 23:05:58 -0800 (PST) Received: from [192.168.20.7] (c-24-16-212-205.hsd1.wa.comcast.net. [24.16.212.205]) by smtp.gmail.com with ESMTPSA id fl9sm7060900pab.33.2016.01.21.23.05.56 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 21 Jan 2016 23:05:57 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\)) Subject: Re: svn commit: r294536 - head/sys/netinet From: NGie Cooper In-Reply-To: <56A1C9F6.2010708@freebsd.org> Date: Thu, 21 Jan 2016 23:05:55 -0800 Cc: Gleb Smirnoff , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: 7bit Message-Id: References: <201601212253.u0LMrC7B016136@repo.freebsd.org> <56A1C9F6.2010708@freebsd.org> To: Lawrence Stewart X-Mailer: Apple Mail (2.2104) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Jan 2016 07:05:59 -0000 > On Jan 21, 2016, at 22:19, Lawrence Stewart wrote: > > Hi Gleb, > > On 01/22/16 09:53, Gleb Smirnoff wrote: >> Author: glebius >> Date: Thu Jan 21 22:53:12 2016 >> New Revision: 294536 >> URL: https://svnweb.freebsd.org/changeset/base/294536 >> >> Log: >> Refactor TCP_CONGESTION setsockopt handling: >> - Use M_TEMP instead of stack variable. >> - Unroll error handling, removing several levels of indentation. > > As noted privately elsewhere, this change introduces races with respect > to CC algorithm module unloading which will need to be fixed. Just > mentioning it again publicly so others are aware of it. That sounds like it deserves a bug...