From owner-freebsd-current@freebsd.org Mon Jul 31 23:39:46 2017 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9F659DC03D8 for ; Mon, 31 Jul 2017 23:39:46 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf0-x231.google.com (mail-pf0-x231.google.com [IPv6:2607:f8b0:400e:c00::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 66ADC6DC1A; Mon, 31 Jul 2017 23:39:46 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pf0-x231.google.com with SMTP id d67so449698pfc.0; Mon, 31 Jul 2017 16:39:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:mime-version:from:in-reply-to:date:cc:message-id:references :to; bh=1NsZO1l5rfVjd9tyejLKc5o9i7dp7uTpLW0dr5hqrVA=; b=RPtgDAH5+Ja9cFq2OI9EXBjVaClCoAb0MPY1TAvdW4OZsIm/kqiWD2OEk0q0O8YBXM loorVCVwEWhnxoLrSe5lx+daekD423/c/vqetRcM6b+O/7hC7tIV2k7jB8nlSXcSUP3m c6FNWu/XH4NywUJ9pC5y5L10v3J58oSiq9PV8PYxTBbAzywYhsQkVOZkHdM5G7nX6udU t7u5Zh6hqhC2hVKlovIu+FfOk8V8ZnpYyRyaAMrFKsRG0T8i+/Pr/aGzR7DmZ626uRaO ewvJSK8I3zXsKFu8fTQipl5wLUOXqDDU60WtKkizJ8HfXNU9LkcvHrh6tMGJUlH2kuBH S1pQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:mime-version:from:in-reply-to:date:cc :message-id:references:to; bh=1NsZO1l5rfVjd9tyejLKc5o9i7dp7uTpLW0dr5hqrVA=; b=KctTGPqG9fHNB0dsWEEQYJ4xgaCUkUvXWAZw+IMPQFnEJViSWoIFwrbZe/0zZj6SUp 9nElXboIMdxSyjk0GMyWu0YPvij1GVGriQ9Kde1FOb0/Q72cSZYVaDKC9gQQGxlrapMs jeIHQzynjQ9M+BnvVbU+cd4/ndoVsYAHHqGxYg5k+Z3Br2JLujA6kQsFcKZy85iHCw1g S8MQijMgoAHD0JR50SGmu/Z7H1h+gGcnJLr71IXb6Wrocr8A4g2b+/vN+tD4/ZFu5OJP skNKIHCkBJjVhN3E8vn9e7O5dhS+/9Dq3QMWu27Ygkb5DlQE6FFS2EL1ctWh23Jbky08 9Njg== X-Gm-Message-State: AIVw111GvmUVsqKxmiZnMKP9j4uIjybwPy8Lth1Y6Vff70zW3leBgVGS YoGWiKj9OxLv+9VgELc= X-Received: by 10.99.161.9 with SMTP id b9mr1207517pgf.144.1501544385671; Mon, 31 Jul 2017 16:39:45 -0700 (PDT) Received: from pinklady.local (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id r25sm361102pgu.7.2017.07.31.16.39.43 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 31 Jul 2017 16:39:44 -0700 (PDT) Subject: Re: tools/tools/zfsboottest doesn't compile on ^/head Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: multipart/signed; boundary="Apple-Mail=_DD2D47BA-AF36-4ED4-8CEA-7C238E57459B"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail From: "Ngie Cooper (yaneurabeya)" In-Reply-To: Date: Mon, 31 Jul 2017 16:39:42 -0700 Cc: FreeBSD Current , Andriy Gapon Message-Id: <0F46FDB8-FED5-41CD-BABD-EB0D07D85940@gmail.com> References: To: Dimitry Andric , Toomas Soome X-Mailer: Apple Mail (2.3124) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Jul 2017 23:39:46 -0000 --Apple-Mail=_DD2D47BA-AF36-4ED4-8CEA-7C238E57459B Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Jul 31, 2017, at 16:21, Ngie Cooper wrote: >=20 > Hi, > It looks like zfsboottest no longer compiles on ^/head (guessing = it has to do with the clang upgrade). > If someone doesn=E2=80=99t fix this build breakage in the next = few hours, I=E2=80=99ll take a stab at fixing it. > Thanks, > -Ngie >=20 > PS zfsboottest should really be compiled with world if MK_ZFS !=3D no. >=20 > $ (cd tools/tools/zfsboottest/; make obj; make) > cc -O1 -I/usr/src/tools/tools/zfsboottest/../../../sys/boot/zfs = -I/usr/src/tools/tools/zfsboottest/../../../sys/cddl/boot/zfs -I. = -fdiagnostics-show-option -W -Wextra -Wno-sign-compare = -Wno-unused-parameter -m32 -g --coverage -MD -MF.depend.zfsboottest.o = -MTzfsboottest.o -std=3Dgnu99 -fstack-protector-strong = -Qunused-arguments -c /usr/src/tools/tools/zfsboottest/zfsboottest.c -o = zfsboottest.o > In file included from = /usr/src/tools/tools/zfsboottest/zfsboottest.c:56: > = /usr/src/tools/tools/zfsboottest/../../../sys/boot/zfs/zfsimpl.c:797:9: = error: returning 'void' from a function with incompatible result type = 'int' > return (pager_output(line)); > ^~~~~~~~~~~~~~~~~~~~ > = /usr/src/tools/tools/zfsboottest/../../../sys/boot/zfs/zfsimpl.c:2356:17: = warning: array index 264 is past the end of the array (which contains = 192 elements) [-Warray-bounds] > memcpy(path, &dn->dn_bonus[sizeof(znode_phys_t)], = psize); > ^ ~~~~~~~~~~~~~~~~~~~~ > = /usr/src/tools/tools/zfsboottest/../../../sys/cddl/boot/zfs/zfsimpl.h:910:= 2: note: array 'dn_bonus' declared here > uint8_t dn_bonus[DN_MAX_BONUSLEN - sizeof (blkptr_t)]; > ^ > 1 warning and 1 error generated. > *** Error code 1 >=20 > Stop. > make: stopped in /usr/src/tools/tools/zfsboottest >=20 > 157873 imp void > 157873 imp printf(const char *fmt,=E2=80=A6) > 104679 phk static void printf(const char *,...); The declaration for putchar is not ANSI compliant either =E2=80=94= which is probably another fun hurdle that someone=E2=80=99s going to = have to deal with in terms of fixing sys/boot and libstand. Thanks, -Ngie --Apple-Mail=_DD2D47BA-AF36-4ED4-8CEA-7C238E57459B Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJZf7+/AAoJEPWDqSZpMIYVTd8P/itk5p6law0iQd8n6If/9DgI py6TZhD+N8F+3yI7R2H0T5JN9anhuTWDkhscBdPMiiO6Ez9mkG7V4zIjdr1DgyKs F6qmkJ1kV2XWoMlmudRfV+wm04RNGL9L9jLB3ICBHEEQ6pLknMk4DSPNciBRI3nK KWcN8gcxyiSBvUSrZZDuspSNF3W4QEg3Hoq/Rt+tjcpGvLLR8Cpz9/DDyGWmTgyu nbPLNMpTwyHVLkJc0a8vTRvH5RMmDWtuuDBc5Cn8KeNc2U4FSNheyKp5TDXWcqs8 /Bs05CzUWgEZs5mhSrjWfGvjy2sBdRyudZt+ZTuicIedmgN5bT/i55loegc/7vQ8 7yHLyRMK9LpR4KybohbhAesfXti5ph+jUzSQkY3+XM/M2G3It9Fk0y9p9iIBw6eE Cn7Yrrq1gA0pglkeoiXlQSLqlB+8hUuBZF2eULX6X/XjB6CYdQf+mTKXuk8/2uuM 1EYzleibca2mWtYKTjLs5sLIFl+//FEPJKRC4tHTx1TLv2M45W5PcVLSAaSe5K/C 6vUaVhS1K0h/JqEoBUDRzE03++d5MSNUNmT4VijlKpNdUp1VEp8FaWesJWOgJN1v ljcAn1lO7nxilrc3kypudWTbAByG9Xytu8GPu2mVjXsDKmEmVCYyG5GnAlZ4Zq+y 2zsucftXyqjMZCxD1N4j =EoC8 -----END PGP SIGNATURE----- --Apple-Mail=_DD2D47BA-AF36-4ED4-8CEA-7C238E57459B--