From owner-freebsd-current@FreeBSD.ORG Sat Oct 9 16:31:07 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8D22816A4CE for ; Sat, 9 Oct 2004 16:31:07 +0000 (GMT) Received: from spider.deepcore.dk (cpe.atm2-0-53484.0x50a6c9a6.abnxx9.customer.tele.dk [80.166.201.166]) by mx1.FreeBSD.org (Postfix) with ESMTP id BC3F843D3F for ; Sat, 9 Oct 2004 16:31:06 +0000 (GMT) (envelope-from sos@DeepCore.dk) Received: from [194.192.25.143] (laptop.deepcore.dk [194.192.25.143]) by spider.deepcore.dk (8.12.11/8.12.10) with ESMTP id i99GV2A0051127; Sat, 9 Oct 2004 18:31:04 +0200 (CEST) (envelope-from sos@DeepCore.dk) Message-ID: <4168123B.20100@DeepCore.dk> Date: Sat, 09 Oct 2004 18:30:51 +0200 From: =?ISO-8859-1?Q?S=F8ren_Schmidt?= User-Agent: Mozilla Thunderbird 0.7.2 (X11/20040802) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Florian Le Goff References: In-Reply-To: Content-Type: multipart/mixed; boundary="------------070709000904040807020605" X-mail-scanned: by DeepCore Virus & Spam killer v1.4 cc: current@freebsd.org cc: Aurelien NEPHTALI Subject: Re: patch: udma5 support for Intel 82801FB ICH6 Ultra ATA Controller X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 09 Oct 2004 16:31:07 -0000 This is a multi-part message in MIME format. --------------070709000904040807020605 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Florian Le Goff wrote: > Hi, >=20 > I've got an ASUS P5GD1 [1] Motherboard, with a 915P chipset and a > ICH6R [2] southbridge. >=20 > Since the UDMA controller was recognized as an "GENERIC ATA > controller", I was stuck in UDMA33 mode for my Seagate Ultra ATA/100 > IDE hard drive, and I wasn't able to change the settings using > "atacontrol mode". Since there is already a great list of Intel > supported chipsets in src/sys/dev/ata/ata-chipset.c, I've added the > references of the chip in ata-chipset.c and ata-pci.h, on a fresh > cvsuped 6.0-CURRENT. >=20 > Please, someone could review it ? My first patch :/ You could just add a define for the other one as well (se attached=20 patch) and have the SATA ports usable as well. Now as wonderfull as this might be, we want to support the ACHI part of=20 the ICH6 for SATA support. That is a totally different animal much like=20 the Promise and Marvell controllers, and is in the works here but will=20 not be ready for 5.3 is the current timelines holds. Actually I should commit that to -current since it at least allows the=20 ICH6 to be used in legacy mode.. --=20 -S=F8ren --------------070709000904040807020605 Content-Type: text/plain; name="ich6-p1" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="ich6-p1" Index: ata-chipset.c =================================================================== RCS file: /home/ncvs/src/sys/dev/ata/ata-chipset.c,v retrieving revision 1.91 diff -u -r1.91 ata-chipset.c --- ata-chipset.c 6 Oct 2004 19:46:07 -0000 1.91 +++ ata-chipset.c 9 Oct 2004 16:16:20 -0000 @@ -833,6 +833,9 @@ { ATA_I6300ESB, 0, 0, 0x00, ATA_UDMA5, "Intel 6300ESB" }, { ATA_I6300ESB_S1,0, 0, 0x00, ATA_SA150, "Intel 6300ESB" }, { ATA_I6300ESB_R1,0, 0, 0x00, ATA_SA150, "Intel 6300ESB" }, + { ATA_I82801FB, 0, 0, 0x00, ATA_UDMA5, "Intel ICH6" }, + { ATA_I82801FB_S1,0, 0, 0x00, ATA_SA150, "Intel ICH6" }, + { ATA_I82801FB_R1,0, 0, 0x00, ATA_SA150, "Intel ICH6" }, { 0, 0, 0, 0, 0, 0}}; char buffer[64]; Index: ata-pci.h =================================================================== RCS file: /home/ncvs/src/sys/dev/ata/ata-pci.h,v retrieving revision 1.34 diff -u -r1.34 ata-pci.h --- ata-pci.h 6 Oct 2004 19:46:08 -0000 1.34 +++ ata-pci.h 9 Oct 2004 16:21:28 -0000 @@ -121,6 +121,9 @@ #define ATA_I6300ESB 0x25a28086 #define ATA_I6300ESB_S1 0x25a38086 #define ATA_I6300ESB_R1 0x25b08086 +#define ATA_I82801FB 0x266f8086 +#define ATA_I82801FB_S1 0x26518086 +#define ATA_I82801FB_R1 0x26528086 #define ATA_NATIONAL_ID 0x100b #define ATA_SC1100 0x0502100b --------------070709000904040807020605--