From owner-freebsd-threads@FreeBSD.ORG Tue Oct 11 23:36:51 2005 Return-Path: X-Original-To: threads@freebsd.org Delivered-To: freebsd-threads@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0AFCC16A420; Tue, 11 Oct 2005 23:36:51 +0000 (GMT) (envelope-from mi+mx@aldan.algebra.com) Received: from blue.virtual-estates.net (aldan.algebra.com [216.254.65.224]) by mx1.FreeBSD.org (Postfix) with ESMTP id 86D1043D45; Tue, 11 Oct 2005 23:36:49 +0000 (GMT) (envelope-from mi+mx@aldan.algebra.com) Received: from corbulon.video-collage.com (static-151-204-231-237.bos.east.verizon.net [151.204.231.237]) by blue.virtual-estates.net (8.13.4/8.13.4) with ESMTP id j9BNamaK024178 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 11 Oct 2005 19:36:48 -0400 (EDT) (envelope-from mi+mx@aldan.algebra.com) Received: from mteterin.us.murex.com (195-11.customer.cloud9.net [168.100.195.11]) by corbulon.video-collage.com (8.13.4/8.13.1) with ESMTP id j9BNa7Bm015349 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 11 Oct 2005 19:36:42 -0400 (EDT) (envelope-from mi+mx@aldan.algebra.com) Received: from mteterin.us.murex.com (mteterin@localhost [127.0.0.1]) by mteterin.us.murex.com (8.13.3/8.13.3) with ESMTP id j9BNZGEc017699; Tue, 11 Oct 2005 19:35:26 -0400 (EDT) (envelope-from mi+mx@aldan.algebra.com) Received: by mteterin.us.murex.com (8.13.3/8.13.3/Submit) id j9BNZ1GQ017691; Tue, 11 Oct 2005 19:35:01 -0400 (EDT) (envelope-from mi+mx@aldan.algebra.com) X-Authentication-Warning: mteterin.us.murex.com: mteterin set sender to mi+mx@aldan.algebra.com using -f From: Mikhail Teterin Organization: Virtual Estates, Inc. To: Daniel Eischen Date: Tue, 11 Oct 2005 19:34:55 -0400 User-Agent: KMail/1.8.2 References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="koi8-u" Content-Transfer-Encoding: 8bit Content-Disposition: inline Message-Id: <200510111934.56300.mi+mx@aldan.algebra.com> X-Virus-Scanned: ClamAV devel-20050525/1128/Mon Oct 10 21:30:06 2005 on corbulon.video-collage.com X-Virus-Status: Clean X-Scanned-By: MIMEDefang 2.43 Cc: threads@freebsd.org, re@freebsd.org Subject: Re: debug defines in libc_r on 6.0 X-BeenThere: freebsd-threads@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Threading on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Oct 2005 23:36:51 -0000 צ×ÔÏÒÏË 11 ÖÏ×ÔÅÎØ 2005 19:00, Daniel Eischen ÷É ÎÁÐÉÓÁÌÉ: > No, it's only a couple of instructions for a very few operations. > I've already replied to you about these before. šI don't care > whether re@ turns them off or not, but go read my prior email > on this topic. šI should eliminate the #defines and always do > the checks, so you wouldn't notice :( We make such checks (however inexpensive) conditional on various DEBUG* and INVARIANTS* flags in the kernel and userspace should be no different. The whole idea of assert() is to provide a way to add debugging checks, which -- however cheap they are -- can be easily removed from a _release_ version of one's software. I remember your e-mail and continue to disagree with it -- the debugging information and checks are, understandably, precious to you, but if we lose, say, a MySQL benchmark by even a small percentage, the advocacy loss will be immense... IMHO, the flags should be removed in RELENG_6, or, at least, in RELENG_6_0. Respectfully, -mi