From owner-svn-ports-all@freebsd.org Sat Dec 17 17:17:02 2016 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EE313C857BF; Sat, 17 Dec 2016 17:17:02 +0000 (UTC) (envelope-from thomas.e.zander@googlemail.com) Received: from mail-oi0-x241.google.com (mail-oi0-x241.google.com [IPv6:2607:f8b0:4003:c06::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A8FCDB92; Sat, 17 Dec 2016 17:17:02 +0000 (UTC) (envelope-from thomas.e.zander@googlemail.com) Received: by mail-oi0-x241.google.com with SMTP id f201so14281344oib.0; Sat, 17 Dec 2016 09:17:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-transfer-encoding; bh=T+MCeXeJihRFnG7WiXzXQkbLqjHu+qHbIAKTd8tuvkc=; b=esb1/NfFzGMSksj+Ct0D428yTuNOxsqnbqljEPdprFNlVTaCBW6UHaSRQ1pE9S71is 9RO/1O3SPUelcPMb3nTrtBNO9ciILpL56jbyoIY64dotNatNU7IlZWep8XvYW7f56L7y TR2Cm38KZA8YELz8CyvEMbLm5dS+ObfskbKNXcBhMUePInrd9v6xh1YTrkuYOl8Sp+Tq gU2dNZ9uszhMiUOWKJdxSr97jIxgy78PdOgA2ZvzyMQG7Q2w1rW+u6FPCR+aKg6wK5mR v/vVlT1fQ6cG2uiHuAN9TdU0dO3Mnikt73E7UThbVFvYtboAjyPEOFP5YskSpTyXCpuH csBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-transfer-encoding; bh=T+MCeXeJihRFnG7WiXzXQkbLqjHu+qHbIAKTd8tuvkc=; b=iba6czINPJktZhYl4Yvl8kW01jHYUQ/PnocQZ6VxNO8bjlbpIgHBKXwbiQvQbT1on+ ZqLEiSCujatyHl1yHwd7aEHHB9f3kZqxbvqsX7ehFw/4FqZpz95pjkco8JhrPLjNh6t+ RsOunEeay4jsfx+aE8hOmot0mo4071eDx29XP2EczNkJW5K+suYy+kcadDTe6ls3yQ+3 CHteV1XC0Kpl8xg7fKSfUMzSBpK0gNVt4yFkQbDILGQKIYT437aNzhpa8mlIzfdCbTJQ eA1T2BMkMWvFFltAoEB03RFuLbPUDpj26YKIlq7NoDao/8WvpghxqScDsXcyvYoFRxjw ihhw== X-Gm-Message-State: AIkVDXK/meNZEkpso6LfETVMui8Uhq2olhpWYe10lFIZXaJpsrFHKyVMrGpq241pEfxqb+wWwDMKRlSDbuCpHg== X-Received: by 10.202.241.130 with SMTP id p124mr4739783oih.85.1481995021701; Sat, 17 Dec 2016 09:17:01 -0800 (PST) MIME-Version: 1.0 Sender: thomas.e.zander@googlemail.com Received: by 10.202.46.84 with HTTP; Sat, 17 Dec 2016 09:17:01 -0800 (PST) In-Reply-To: References: <201612171341.uBHDfWIF098306@repo.freebsd.org> <8e01a684-eef8-a3ab-1cea-757db5879feb@FreeBSD.org> From: Thomas Zander Date: Sat, 17 Dec 2016 18:17:01 +0100 X-Google-Sender-Auth: 9R63rk3n2n1ncmuKRbLqGLYz158 Message-ID: Subject: Re: svn commit: r428763 - in head/audio/fluidsynth: . files To: Mathieu Arnold Cc: "ports-committers@FreeBSD.org" , svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Dec 2016 17:17:03 -0000 On 17 December 2016 at 18:00, Mathieu Arnold wrote: > Le 17/12/2016 =C3=A0 17:38, Thomas Zander a =C3=A9crit : >> On 17 December 2016 at 14:50, Mathieu Arnold wrote: >>> Le 17/12/2016 =C3=A0 14:41, Thomas Zander a =C3=A9crit : >>>> Modified: head/audio/fluidsynth/Makefile >>>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D >>>> --- head/audio/fluidsynth/Makefile Sat Dec 17 13:26:05 2016 = (r428762) >>>> +++ head/audio/fluidsynth/Makefile Sat Dec 17 13:41:32 2016 = (r428763) >>>> @@ -13,7 +13,7 @@ COMMENT=3D Real-time software synthesizer >>>> LICENSE=3D LGPL20 >>>> LICENSE_FILE=3D ${WRKSRC}/COPYING >>>> >>>> -OPTIONS_DEFINE=3D JACK ALSA DBUS LADSPA LASH PORTAUDIO PULSEAUDI= O SNDFILE >>>> +OPTIONS_DEFINE=3D JACK ALSA DBUS LADSPA LASH PORTAUDIO PULSEAUDI= O SNDFILE SNDIO >>>> OPTIONS_DEFAULT=3D JACK >>> This is missing a PORTREVISION bump. >> Since when? The new SNDIO knob is disabled by default and the default >> package remains unchanged. > > First, because, well, it is the rule[1]. You changed the options list, > so the package can change, so it must be bumped. Thanks for pointing to the doc. However, I specifically remember discussions about NOT bumping in case the default package remains unchanged, the goal being to avoid futile rebuild of packages. That was the rationale for not bumping. But if it's the rule, sure, don't want to break any laws here :-) > Second, because if I had built this port before you added the option, > and I had sndio installed, it would be linked with it but there would > not be a dependency recorded. But if I build it after this option is > added, it is not liked with SNDIO any more. Which makes a different > package, which is a big reason for bumping PORTREVISION. That's incorrect. The patch brings in not only the cmake args but the whole sndio output module. fluidsynth before this commit would never link to sndio. So this would have not been a problem at all. Best regards Riggs