Date: Mon, 17 Feb 2025 14:17:51 +0100 From: Jan Beich <jbeich@FreeBSD.org> To: "Jason E. Hale" <jhale@freebsd.org> Cc: Charlie Li <vishwin@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org, awoonyaa@gmail.com Subject: Re: git: a4c87a5576a9 - main - devel/py-libevdev: add new port Message-ID: <cyfg-90cg-wny@FreeBSD.org> In-Reply-To: <CAJE75NEm1vXO3p9dq1hVtt85nPdGSxMnDFUeWxYUsn%2BA-EWj4g@mail.gmail.com> (Jason E. Hale's message of "Mon, 17 Feb 2025 06:31:39 -0500") References: <202502160003.51G03e8A076660@gitrepo.freebsd.org> <34f65a4f-2ab9-4f39-9631-842c47077d5d@freebsd.org> <jz9o-al42-wny@FreeBSD.org> <CAJE75NEm1vXO3p9dq1hVtt85nPdGSxMnDFUeWxYUsn%2BA-EWj4g@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
"Jason E. Hale" <jhale@freebsd.org> writes:
> On Mon, Feb 17, 2025 at 6:04=E2=80=AFAM Jan Beich <jbeich@freebsd.org> wr=
ote:
>
>>
>> Charlie Li <vishwin@freebsd.org> writes:
>>
>> > Needs LIB_DEPENDS on devel/libevdev.
>>
>> Done in bc369d345016.
>>
>> > Also the project includes a pytest testing framework so
>> > USE_PYTHON=3Dpytest should be added.
>>
>> Leaving up to the maintainer:
>> - devel/libevdev has -Dtests=3Ddisabled, so why enable here?
>> - /dev/uinput fails inside jail to create synthetic /dev/input/*
>> - Some tests fail for other reasons e.g., missing linsysfs(4) node
>> - USES=3Dpytest doesn't work for me WITH_TESTING=3Dyes (d7700ff7fde6)
>
> The python tests are separate. USES=3Dpytest is not valid, it should be
> USE_PYTHON=3Dpytest.
Sorry, I forgot USES=3Dpytest exists and meant USE_PYTHON=3Dpytest.
Even devel/py-pytest itself fails WITH_TESTING=3Dyes for me.
I don't maintain this port to trust my own manual testing.
> The tests work fine for me.
Did you run tests as root user? Otherwise, /dev/uinput tests are skipped.
Did you run tests via poudriere? Otherwise, tests run fine (with failures).
> This port should also be built with USE_PYTHON=3Dpep517, not distutils.
> To make this happen, the port also needs:
> BUILD_DEPENDS=3D ${PY_SETUPTOOLS} \
>
> ${PYTHON_PKGNAMEPREFIX}wheel>0:devel/py-wheel@${PY_FLAVOR}
I disagree. Upstream doesn't ship pyproject.toml.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?cyfg-90cg-wny>