From owner-svn-src-user@FreeBSD.ORG Tue Oct 13 20:07:34 2009 Return-Path: Delivered-To: svn-src-user@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8B1C61065670 for ; Tue, 13 Oct 2009 20:07:34 +0000 (UTC) (envelope-from julian@elischer.org) Received: from outQ.internet-mail-service.net (outq.internet-mail-service.net [216.240.47.240]) by mx1.freebsd.org (Postfix) with ESMTP id 715AF8FC0A for ; Tue, 13 Oct 2009 20:07:34 +0000 (UTC) Received: from idiom.com (mx0.idiom.com [216.240.32.160]) by out.internet-mail-service.net (Postfix) with ESMTP id B14C6D2525; Tue, 13 Oct 2009 12:56:22 -0700 (PDT) X-Client-Authorized: MaGic Cook1e X-Client-Authorized: MaGic Cook1e X-Client-Authorized: MaGic Cook1e X-Client-Authorized: MaGic Cook1e Received: from julian-mac.elischer.org (home.elischer.org [216.240.48.38]) by idiom.com (Postfix) with ESMTP id 03F692D6019; Tue, 13 Oct 2009 12:56:21 -0700 (PDT) Message-ID: <4AD4DB68.2060202@elischer.org> Date: Tue, 13 Oct 2009 12:56:24 -0700 From: Julian Elischer User-Agent: Thunderbird 2.0.0.23 (Macintosh/20090812) MIME-Version: 1.0 To: John Baldwin References: <200910122226.n9CMQAYr087381@svn.freebsd.org> <200910130756.32986.jhb@freebsd.org> In-Reply-To: <200910130756.32986.jhb@freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Ermal LuXi , src-committers@freebsd.org, svn-src-user@freebsd.org Subject: Re: svn commit: r198007 - user/eri/pf45/head/sys/contrib/pf/net X-BeenThere: svn-src-user@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the experimental " user" src tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Oct 2009 20:07:34 -0000 John Baldwin wrote: > On Monday 12 October 2009 6:26:10 pm Ermal LuXi wrote: >> Author: eri >> Date: Mon Oct 12 22:26:10 2009 >> New Revision: 198007 >> URL: http://svn.freebsd.org/changeset/base/198007 >> >> Log: >> * Prefix some other variables with V_ since their name is the same as > their struct type. >> * For being virtualization ready only contexes should be considered > especially in event handlers. > > FWIW, I think it will be simpler to just have all virtualized variables start > with V_ rather than having a partial mix. They should either all have V_ or > none of them have V_ as anything else will just be confusing. And since the > case of none of them having V_ doesn't compile that narrows it down. :) > Ermal, have you asked the OpenBSD guys if they'd accept any changes from us that would make it easier? The SCTP guys agreed to put "SCTP_GLOBAL(name)" around their globals with the comment that it would help them in their user-land version. I do know that OpenBSD agreeing to do something purely for someone else would be a rather drastic departure from their normal M.O. but you won't know until you ask. Julian