Date: Tue, 13 Oct 2009 12:56:24 -0700 From: Julian Elischer <julian@elischer.org> To: John Baldwin <jhb@freebsd.org> Cc: Ermal LuXi <eri@freebsd.org>, src-committers@freebsd.org, svn-src-user@freebsd.org Subject: Re: svn commit: r198007 - user/eri/pf45/head/sys/contrib/pf/net Message-ID: <4AD4DB68.2060202@elischer.org> In-Reply-To: <200910130756.32986.jhb@freebsd.org> References: <200910122226.n9CMQAYr087381@svn.freebsd.org> <200910130756.32986.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
John Baldwin wrote: > On Monday 12 October 2009 6:26:10 pm Ermal LuXi wrote: >> Author: eri >> Date: Mon Oct 12 22:26:10 2009 >> New Revision: 198007 >> URL: http://svn.freebsd.org/changeset/base/198007 >> >> Log: >> * Prefix some other variables with V_ since their name is the same as > their struct type. >> * For being virtualization ready only contexes should be considered > especially in event handlers. > > FWIW, I think it will be simpler to just have all virtualized variables start > with V_ rather than having a partial mix. They should either all have V_ or > none of them have V_ as anything else will just be confusing. And since the > case of none of them having V_ doesn't compile that narrows it down. :) > Ermal, have you asked the OpenBSD guys if they'd accept any changes from us that would make it easier? The SCTP guys agreed to put "SCTP_GLOBAL(name)" around their globals with the comment that it would help them in their user-land version. I do know that OpenBSD agreeing to do something purely for someone else would be a rather drastic departure from their normal M.O. but you won't know until you ask. Julian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4AD4DB68.2060202>