From owner-cvs-all@FreeBSD.ORG Mon Aug 4 14:08:00 2008 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1440E1065687; Mon, 4 Aug 2008 14:08:00 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net [IPv6:2001:470:1f10:75::2]) by mx1.freebsd.org (Postfix) with ESMTP id A3FA28FC14; Mon, 4 Aug 2008 14:07:59 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from zion.baldwin.cx (zion.baldwin.cx [IPv6:2001:470:1f11:75:2a0:d2ff:fe18:8b38]) (authenticated bits=0) by server.baldwin.cx (8.14.2/8.14.2) with ESMTP id m74E7kru080837; Mon, 4 Aug 2008 10:07:53 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Konstantin Belousov Date: Mon, 4 Aug 2008 09:19:07 -0400 User-Agent: KMail/1.9.7 References: <200808031334.m73DY4fR030018@repoman.freebsd.org> In-Reply-To: <200808031334.m73DY4fR030018@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200808040919.08314.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [IPv6:2001:470:1f11:75::1]); Mon, 04 Aug 2008 10:07:53 -0400 (EDT) X-Virus-Scanned: ClamAV 0.93.1/7935/Mon Aug 4 08:58:49 2008 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.5 required=4.2 tests=AWL,BAYES_00,NO_RELAYS autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern link_elf.c link_elf_obj.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Aug 2008 14:08:00 -0000 On Sunday 03 August 2008 09:33:45 am Konstantin Belousov wrote: > kib 2008-08-03 13:33:45 UTC > > FreeBSD src repository > > Modified files: > sys/kern link_elf.c link_elf_obj.c > Log: > SVN rev 181235 on 2008-08-03 13:33:45Z by kib > > Calling linker_load_dependencies() while holding the module' > vnode lock may cause a LOR between kld_sx lock and vnode lock. > linker_load_dependencies() drops kld_sx, and another thread may attempt > to load the same kld. > > Reported and tested by: pjd > MFC after: 1 week If it is safe to drop the vnode lock here, is there any reason we can't just drop it earlier and not bother reacquiring it? -- John Baldwin