From owner-freebsd-gecko@freebsd.org Fri Sep 1 23:39:53 2017 Return-Path: Delivered-To: freebsd-gecko@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 111CBE0EB98 for ; Fri, 1 Sep 2017 23:39:53 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: from mailman.ysv.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id F37EA692C2 for ; Fri, 1 Sep 2017 23:39:52 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id EFD2FE0EB97; Fri, 1 Sep 2017 23:39:52 +0000 (UTC) Delivered-To: gecko@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EF7E8E0EB96 for ; Fri, 1 Sep 2017 23:39:52 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D069D692C1; Fri, 1 Sep 2017 23:39:52 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1354) id 1BCCED82B; Fri, 1 Sep 2017 23:39:52 +0000 (UTC) From: Jan Beich To: Francois Marier Cc: gecko@FreeBSD.org, =?utf-8?Q?Ren=C3=A9?= Ladan Subject: Re: Firefox 56 in FreeBSD: Safe Browsing API key required References: <7a098f0b-2412-5ea5-5378-eb36c68fee2a@mozilla.com> Date: Sat, 02 Sep 2017 01:39:45 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: freebsd-gecko@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Gecko Rendering Engine issues List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Sep 2017 23:39:53 -0000 Francois Marier writes: > On 07/08/17 09:37 PM, Jan Beich wrote: > >>> If you are indeed already including a Google API key in your builds, >>> then all you need to do is to add the Safe Browsing API to it, see >>> https://bugzilla.mozilla.org/show_bug.cgi?id=1377987#c0. >> >> Does SafeBrowsing require defining MOZILLA_OFFICIAL during build which >> would also enable Telemetry pings? > > Are you defining MOZILLA_OFFICIAL in your builds? No, for now. Other downstream maintainers do, see https://bugzilla.mozilla.org/show_bug.cgi?id=1352981 > >>> Afterwards, if you send me the project ID (not the API key), I can >>> liaise with Google to make sure it has the right access and appropriate >>> quota. >> >> Our gecko@ team shares Google API key with chromium@ team. rene@ was the >> one who originally obtained the key, so maybe he still has the project ID. > > I just verified your API key in a custom build of Firefox and it will > work for basic Safe Browsing V4 support as long as you don't set > MOZILLA_OFFICIAL. Doesn't seem to work, at least on firefox-56.0b6. listmanager: [trimmed-timestamp]: stateArray: ,,,, listmanager: [trimmed-timestamp]: update request: { "tableList": "goog-phish-proto,goog-malware-proto,goog-unwanted-proto,goog-badbinurl-proto,goog-downloadwhite-proto", "tableNames": { "goog-phish-proto": true, "goog-malware-proto": true, "goog-unwanted-proto": true, "goog-badbinurl-proto": true, "goog-downloadwhite-proto": true }, "requestPayload": "CgkKB0ZpcmVmb3gaCggFEAIiAiACKAEaCggBEAIiAiACKAEaCggDEAIiAiACKAEaCggHEAIiAiACKAEaCggJEAIiAiACKAE=", "isPostRequest": false } listmanager: [trimmed-timestamp]: makeUpdateRequestForEntry_: requestPayload CgkKB0ZpcmVmb3gaCggFEAIiAiACKAEaCggBEAIiAiACKAEaCggDEAIiAiACKAEaCggHEAIiAiACKAEaCggJEAIiAiACKAE= update: https://safebrowsing.googleapis.com/v4/threatListUpdates:fetch?$ct=application/x-protobuf&key=[trimmed-google-api-key]&$httpMethod=POST tablelist: goog-phish-proto,goog-malware-proto,goog-unwanted-proto,goog-badbinurl-proto,goog-downloadwhite-proto listmanager: [trimmed-timestamp]: download error for goog-phish-proto,goog-malware-proto,goog-unwanted-proto,goog-badbinurl-proto,goog-downloadwhite-proto: 403