From owner-freebsd-ports@FreeBSD.ORG Sun Sep 25 23:58:30 2005 Return-Path: X-Original-To: freebsd-ports@freebsd.org Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 51E0F16A41F for ; Sun, 25 Sep 2005 23:58:30 +0000 (GMT) (envelope-from ringworm01@gmail.com) Received: from xproxy.gmail.com (xproxy.gmail.com [66.249.82.198]) by mx1.FreeBSD.org (Postfix) with ESMTP id D3AD843D48 for ; Sun, 25 Sep 2005 23:58:27 +0000 (GMT) (envelope-from ringworm01@gmail.com) Received: by xproxy.gmail.com with SMTP id t14so954316wxc for ; Sun, 25 Sep 2005 16:58:27 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:from:to:subject:date:user-agent:references:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:message-id; b=SN20kptzoSh2qICICLzdgRExg6XPe8MeCWjrCTBQtylrY4vEq4qW2JgUplNbE8Z4QevOK/DSOAKDCI7kqDVoA0g4mFgdqy+9UTY3XgJEa6gp3ury6vYhm+mdZ7iVczHTDsoiPDmvEnltPP/NDZhwZT+ozfJLmSrW+D66m/ntPlM= Received: by 10.70.21.12 with SMTP id 12mr2016447wxu; Sun, 25 Sep 2005 16:58:27 -0700 (PDT) Received: from ?192.168.1.10? ( [71.102.7.230]) by mx.gmail.com with ESMTP id h7sm128912wxd.2005.09.25.16.58.25; Sun, 25 Sep 2005 16:58:27 -0700 (PDT) From: "Michael C. Shultz" To: pav@freebsd.org, freebsd-ports@freebsd.org, portmgr@freebsd.org Date: Sun, 25 Sep 2005 16:37:42 -0700 User-Agent: KMail/1.8.2 References: <200509251559.53576.ringworm01@gmail.com> <1127691447.3077.8.camel@ikaros.oook.cz> In-Reply-To: <1127691447.3077.8.camel@ikaros.oook.cz> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Message-Id: <200509251637.44134.ringworm01@gmail.com> Cc: Subject: Re: ports/Mk/bsd.port.mk,v 1.517 2005/09/15 12:24:33 question X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 25 Sep 2005 23:58:30 -0000 On Sunday 25 September 2005 16:37, Pav Lucistnik wrote: > Michael C. Shultz p=C3=AD=C5=A1e v ne 25. 09. 2005 v 15:59 -0700: > > Is it possible/desirable to modify bsd.port.mk so that > > ports marked IGNORE or BROKEN exit with an error > > code, like "make check-conflicts" does if there is a conflict? > > > > Right now there is a problem with sysutils/portmanager > > not properly handling ports marked BROKEN because > > make seems to exit with no error. I could add parsing > > Makefiles for the term "BROKEN" to portmanager, but that > > seems a shame, because untill now portmanager has never > > needed to snoop the insides of Makefiles. > > what about running "make -V BROKEN" ? That still seems to return no error code. I'm no perl programmer, but I tried adding this to bsd.port.mk just below check-conflicts: =2Eif !target(check-broken) check-broken: =2Eif defined(BROKEN) ${ECHO_MSG}; \ ${ECHO_MSG} "=3D=3D=3D=3D> ${PKGNAME} marked broken"; \ exit 1 =2Eendif =2Eendif It works for my purposes, but I've never tried submitting anything on the=20 ports infrastructure, do you think this would fly? It sure would make my=20 life easier, because all I would have to do is test "make check-broken"=20 target. =2DMike