From owner-freebsd-geom@FreeBSD.ORG  Fri Aug  3 20:30:17 2012
Return-Path: <owner-freebsd-geom@FreeBSD.ORG>
Delivered-To: freebsd-geom@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id ADF4E1065675
	for <freebsd-geom@hub.freebsd.org>;
	Fri,  3 Aug 2012 20:30:17 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 994698FC19
	for <freebsd-geom@hub.freebsd.org>;
	Fri,  3 Aug 2012 20:30:17 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q73KUHAg056608
	for <freebsd-geom@freefall.freebsd.org>; Fri, 3 Aug 2012 20:30:17 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q73KUHPG056605;
	Fri, 3 Aug 2012 20:30:17 GMT (envelope-from gnats)
Date: Fri, 3 Aug 2012 20:30:17 GMT
Message-Id: <201208032030.q73KUHPG056605@freefall.freebsd.org>
To: freebsd-geom@FreeBSD.org
From: dfilter@FreeBSD.ORG (dfilter service)
Cc: 
Subject: Re: kern/170199: commit references a PR
X-BeenThere: freebsd-geom@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: dfilter service <dfilter@FreeBSD.ORG>
List-Id: GEOM-specific discussions and implementations
	<freebsd-geom.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-geom>,
	<mailto:freebsd-geom-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-geom>
List-Post: <mailto:freebsd-geom@freebsd.org>
List-Help: <mailto:freebsd-geom-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-geom>,
	<mailto:freebsd-geom-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 03 Aug 2012 20:30:17 -0000

The following reply was made to PR kern/170199; it has been noted by GNATS.

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/170199: commit references a PR
Date: Fri,  3 Aug 2012 20:24:31 +0000 (UTC)

 Author: jimharris
 Date: Fri Aug  3 20:24:16 2012
 New Revision: 239021
 URL: http://svn.freebsd.org/changeset/base/239021
 
 Log:
   In virstor_ctl_stop(), check for a valid softc before trying to update
    metadata.
   
   Sponsored by:		Intel
   Reported and tested by:	Marcelo Gondim <gondim at bsdinfo dot com dot br>
   PR:			kern/170199
   MFC after:		3 days
 
 Modified:
   head/sys/geom/virstor/g_virstor.c
 
 Modified: head/sys/geom/virstor/g_virstor.c
 ==============================================================================
 --- head/sys/geom/virstor/g_virstor.c	Fri Aug  3 18:40:44 2012	(r239020)
 +++ head/sys/geom/virstor/g_virstor.c	Fri Aug  3 20:24:16 2012	(r239021)
 @@ -235,6 +235,12 @@ virstor_ctl_stop(struct gctl_req *req, s
  			return;
  		}
  		sc = virstor_find_geom(cp, name);
 +		if (sc == NULL) {
 +			gctl_error(req, "Don't know anything about '%s'", name);
 +			g_topology_unlock();
 +			return;
 +		}
 +
  		LOG_MSG(LVL_INFO, "Stopping %s by the userland command",
  		    sc->geom->name);
  		update_metadata(sc);
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"