From owner-cvs-src@FreeBSD.ORG Thu Jul 14 13:09:04 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 333AF16A41C; Thu, 14 Jul 2005 13:09:04 +0000 (GMT) (envelope-from gallatin@cs.duke.edu) Received: from duke.cs.duke.edu (duke.cs.duke.edu [152.3.140.1]) by mx1.FreeBSD.org (Postfix) with ESMTP id C2DE743D45; Thu, 14 Jul 2005 13:09:03 +0000 (GMT) (envelope-from gallatin@cs.duke.edu) Received: from grasshopper.cs.duke.edu (grasshopper.cs.duke.edu [152.3.145.30]) by duke.cs.duke.edu (8.13.4/8.13.4) with ESMTP id j6ED93kB011830 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 14 Jul 2005 09:09:03 -0400 (EDT) Received: (from gallatin@localhost) by grasshopper.cs.duke.edu (8.12.9p2/8.12.9/Submit) id j6ED8wfJ021314; Thu, 14 Jul 2005 09:08:58 -0400 (EDT) (envelope-from gallatin) From: Andrew Gallatin MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <17110.25578.31335.425537@grasshopper.cs.duke.edu> Date: Thu, 14 Jul 2005 09:08:58 -0400 (EDT) To: Gleb Smirnoff In-Reply-To: <20050714125145.GA18744@cell.sick.ru> References: <200507131406.j6DE6DLv066313@repoman.freebsd.org> <20050714083608.A21239@grasshopper.cs.duke.edu> <20050714125145.GA18744@cell.sick.ru> X-Mailer: VM 6.75 under 21.1 (patch 12) "Channel Islands" XEmacs Lucid Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/pci if_xl.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Jul 2005 13:09:04 -0000 Gleb Smirnoff writes: > On Thu, Jul 14, 2005 at 08:36:08AM -0400, Andrew Gallatin wrote: > A> Gleb Smirnoff [glebius@FreeBSD.org] wrote: > A> > glebius 2005-07-13 14:06:13 UTC > A> > > A> > FreeBSD src repository > A> > > A> > Modified files: > A> > sys/pci if_xl.c > A> > Log: > A> > NET_LOCK_GIANT() when entering network code. > A> > > A> > A> Do other drivers do this? It looks like at least em, fxp > A> and my out-of-tree commercial driver have the same "bug". > > They do. Look at if_ath.c:ath_rx_proc(). This is done in functions > that execute from a separate context - from task queue. > em, fxp and others may not have such functions. Ah, I hadn't realized that xl_rxeof() ran from a task queue. I'm not sure I want to know why it does that ;) Thanks for clearing that up. Drew