From owner-dev-commits-src-all@freebsd.org Fri Feb 19 01:07:58 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2701D53335D for ; Fri, 19 Feb 2021 01:07:58 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DhYNG0GWWz4dcG for ; Fri, 19 Feb 2021 01:07:57 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: by mail-wm1-f43.google.com with SMTP id o15so5282549wmq.5 for ; Thu, 18 Feb 2021 17:07:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=gWa3qVEoMESpHZpaw7ZkZE+tWCfG52zEJ+BB4kBIb5I=; b=cY9+64X6ODsk9EjlEH/G6L66lD2bzDxD1+5fwT3NaQrYN9T8wB6WKYGRyHDzYP8SoV HJFPQFsWkCUwQwEa4m3U2GO+KEYlDW6MUusG4z0a0G5fdvia9YtDSwRMXNLiEyQd1tyb pubK5618pnTSyL+WTBtAYSE1dhJs9tQexBnzTYTUmb5JajBe8ewhCshzRJ72Mr2hoEaV a+TIpkmnD6SylvVUT+dwCb7utscPx21YWNSm1rGTB0EqBhhGh2inxUOICmOodtCCGPAO nSEwwYXVeR4MI6hX1CVM4OFx1hq+u64YxeS6CiAxSV0glFLTxrpIL6Yi8kMkT4qBXxj7 d32g== X-Gm-Message-State: AOAM531qzCdnkhAZmIXQWfv169V1y29SfhXm1yDievWOPfwNkC5LgYkT FeHkyxPGo1BTM6eHroONw5QCJQ== X-Google-Smtp-Source: ABdhPJxs6OxEUEeO2OPJHjg+GdePnr0KBNXBgT97h3I12HHzYtUy3xYu4luHqaHoIe7cvDUxw4pYKg== X-Received: by 2002:a1c:cc14:: with SMTP id h20mr5790826wmb.180.1613696876114; Thu, 18 Feb 2021 17:07:56 -0800 (PST) Received: from [192.168.149.251] (trinity-students-nat.trin.cam.ac.uk. [131.111.193.104]) by smtp.gmail.com with ESMTPSA id y15sm11286996wrm.93.2021.02.18.17.07.55 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 18 Feb 2021 17:07:55 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\)) Subject: Re: git: 24fd63e0970f - main - mips: Don't set __NO_TLS to disable some uses of TLS. From: Jessica Clarke In-Reply-To: Date: Fri, 19 Feb 2021 01:07:54 +0000 Cc: Konstantin Belousov , John Baldwin , src-committers , dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <012169A0-67EC-48B7-A1CB-2A9921EF63FA@freebsd.org> References: <202102180035.11I0ZnL3070354@gitrepo.freebsd.org> <9687575c-dd7c-1496-850b-2018f4bca3da@FreeBSD.org> <3045F222-DBAC-463C-B429-075B2CFB115A@freebsd.org> To: Brandon Bergren X-Mailer: Apple Mail (2.3608.120.23.2.4) X-Rspamd-Queue-Id: 4DhYNG0GWWz4dcG X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Feb 2021 01:07:58 -0000 On 19 Feb 2021, at 00:03, Brandon Bergren wrote: > On Thu, Feb 18, 2021, at 6:00 PM, Jessica Clarke wrote: >>=20 >> But TLS isn't broken for ELFv1? Otherwise jemalloc would die in a = fire >> and nothing would ever work. TLS should have been working for ELFv1 = for >> many years by this point. >>=20 >> Jess >=20 > It's not broken, but it's an ABI change to flip it back and forth. You = get RuneLocale errors in the middle of installworld if you try and = install a build with TLS enabled and have to do a double installworld to = compensate for the crashes. >=20 > For ABI stability reasons, it needs to stay on in 12 and below. Ok, so the mistake was not deleting it 8 years ago and instead leaving it around to become part of the ABI. The issue you're referring to specifically is __getCurrentRuneLocale and _ThreadRuneLocale (the latter doesn't exist for __NO_TLS, and the former changes between static inline and extern)? __NO_TLS should have blocked powerpc64 (and mips) from becoming tier 2 IMO, but we're stuck with it, so yeah, it's a major ABI break (frustratingly tiny but breaks the core system libraries) and thus can't be MFC'ed. Jess