From owner-svn-ports-all@freebsd.org Fri Apr 15 18:14:20 2016 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9C9E2AEDD68; Fri, 15 Apr 2016 18:14:20 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 938AE12E5; Fri, 15 Apr 2016 18:14:20 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1033) id 92E14102C; Fri, 15 Apr 2016 18:14:20 +0000 (UTC) Date: Fri, 15 Apr 2016 18:14:20 +0000 From: Alexey Dokuchaev To: Antoine Brodin Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r413364 - head/security/racoon2 Message-ID: <20160415181420.GA96004@FreeBSD.org> References: <201604151757.u3FHvU1V025485@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201604151757.u3FHvU1V025485@repo.freebsd.org> User-Agent: Mutt/1.6.0 (2016-04-01) X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Apr 2016 18:14:20 -0000 On Fri, Apr 15, 2016 at 05:57:30PM +0000, Antoine Brodin wrote: > New Revision: 413364 > URL: https://svnweb.freebsd.org/changeset/ports/413364 > > Log: > Unbreak > > Reported by: pkg-fallout This explains nothing; you should've mentioned that USE_RC_SUBR is now deprecated as of r413252 and state a clear reason for your checkin. Please provide sensible commit logs in the future Antoine, thank you. (Context given below.) ./danfe > Modified: > head/security/racoon2/Makefile > > Modified: head/security/racoon2/Makefile > ============================================================================== > --- head/security/racoon2/Makefile Fri Apr 15 17:49:36 2016 (r413363) > +++ head/security/racoon2/Makefile Fri Apr 15 17:57:30 2016 (r413364) > @@ -11,7 +11,6 @@ MAINTAINER= cy@FreeBSD.org > COMMENT= Racoon2 IPsec daemon > > USES= perl5 tar:tgz > -USE_RC_SUBR= YES