From owner-freebsd-ports-bugs@FreeBSD.ORG  Sat Oct 18 08:59:54 2003
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
Delivered-To: freebsd-ports-bugs@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 52F7016A4B3
	for <freebsd-ports-bugs@FreeBSD.org>;
	Sat, 18 Oct 2003 08:59:54 -0700 (PDT)
Received: from mx2.fillmore-labs.com (lima.fillmore-labs.com [62.138.193.83])
	by mx1.FreeBSD.org (Postfix) with ESMTP id EFA0943FBD
	for <freebsd-ports-bugs@FreeBSD.org>;
	Sat, 18 Oct 2003 08:59:52 -0700 (PDT)
	(envelope-from eikemeier@fillmore-labs.com)
Received: from pd951a8ae.dip.t-dialin.net
	([217.81.168.174] helo=fillmore-labs.com ident=j26zetqa34tqgu49)
	by mx2.fillmore-labs.com with asmtp (TLSv1:AES256-SHA:256)
	(Exim 4.24; FreeBSD 4.9)
	id 1AAtUa-000AFV-CH; Sat, 18 Oct 2003 17:59:48 +0200
Message-ID: <3F91636F.3070701@fillmore-labs.com>
Date: Sat, 18 Oct 2003 17:59:43 +0200
From: Oliver Eikemeier <eikemeier@fillmore-labs.com>
MIME-Version: 1.0
To: Eduard Martinescu <martines@rochester.rr.com>
References: <200310181410.h9IEAKhS076253@freefall.freebsd.org>
In-Reply-To: <200310181410.h9IEAKhS076253@freefall.freebsd.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Authenticated-Sender: eikemeier@fillmore-labs.com
User-Agent: KMail/1.5.9
Organization: Fillmore Labs GmbH  <http://www.fillmore-labs.com/>
X-Complaints-To: abuse@fillmore-labs.com
cc: freebsd-ports-bugs@FreeBSD.org
cc: Sergey Matveychuk <sem@ciam.ru>
Subject: Re: ports/58085: New Port: S.M.A.R.T. disk monitoring tools
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>,
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>,
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 18 Oct 2003 15:59:54 -0000

Hi Eduard,

just some minor suggestions ;->

>  XCONFIGURE_ARGS+= --with-initscriptdir=${PREFIX}/etc/rc.d --with-docdir=${PREFIX}/share/doc/smartmontools --enable-sample
I assume you meant --with-docdir=${DOCSDIR} here?

>  X	@${INSTALL_MAN} ${WRKSRC}/smartctl.8 \
>  X		${PREFIX}/man/man8
>  X	@${INSTALL_MAN} ${WRKSRC}/smartd.conf.5 \
>  X		${PREFIX}/man/man5
>  X	@${INSTALL_MAN} ${WRKSRC}/smartd.8 \
>  X		${PREFIX}/man/man8
You could use ${MAN5PREFIX}/man/man5 and ${MAN8PREFIX}/man/man8 here,
in case someone installs the port with PREFIX=/usr

>  X	@${INSTALL_DATA} ${WRKSRC}/COPYING ${DOCSDIR}
Form the FreeBSD Porter's Handbook, 15.19 Miscellanea:
  http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/dads-misc.html

"Do not copy more copies of the GNU General Public License into our system, please."

Regards
    Oliver