From owner-freebsd-alpha  Mon Dec 17 13: 9:58 2001
Delivered-To: freebsd-alpha@freebsd.org
Received: from mail11.speakeasy.net (mail11.speakeasy.net [216.254.0.211])
	by hub.freebsd.org (Postfix) with ESMTP id D1DCC37B416
	for <alpha@FreeBSD.ORG>; Mon, 17 Dec 2001 13:09:55 -0800 (PST)
Received: (qmail 27085 invoked from network); 17 Dec 2001 21:09:55 -0000
Received: from unknown (HELO laptop.baldwin.cx) ([64.81.54.73]) (envelope-sender <jhb@FreeBSD.org>)
          by mail11.speakeasy.net (qmail-ldap-1.03) with SMTP
          for <jake@locore.ca>; 17 Dec 2001 21:09:55 -0000
Message-ID: <XFMail.011217130941.jhb@FreeBSD.org>
X-Mailer: XFMail 1.4.0 on FreeBSD
X-Priority: 3 (Normal)
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
In-Reply-To: <20011217161037.F39205@locore.ca>
Date: Mon, 17 Dec 2001 13:09:41 -0800 (PST)
From: John Baldwin <jhb@FreeBSD.org>
To: Jake Burkholder <jake@locore.ca>
Subject: Re: Kernel builds broken?
Cc: alpha@FreeBSD.ORG, Adam Kranzel <adam@blacktabby.org>,
	Joerg Wunsch <joerg_wunsch@uriah.heep.sax.de>
Sender: owner-freebsd-alpha@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-alpha.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-alpha>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-alpha>
X-Loop: FreeBSD.org


On 17-Dec-01 Jake Burkholder wrote:
>> > It looks like the ifdefs to skip some of the code for non-i386 are
>> > broken.
>> > 
>> > #if _MACHINE_ARCH == i386 in fd_probe() should be #ifdef __i386__.
>> 
>> Normally not.  #ifdef __i386__ would match the host system type, not
>> the target system.
> 
> Hmm.  I think that the build system will do this correctly.  The
> define for the machine arch is in the compiler specs, so if you
> build with a cross compiler targeting alpha on an i386, it will
> correctly define __alpha__.  All of the other ifdefs of this form
> in the tree are as I describe.

Yep.

>> Why is _MACHINE_ARCH == i386 on an Alpha system?
> 
> Maybe because its spelt MACHINE_ARCH?  I don't know if these defines
> even exist as preprocessor directives, I only know of the make variable.
> As I said, the definition for the machine type is in the compiler specs
> and is __<machine>__.

Yes, we use __<machine>__ all over the kernel.  The fd(4) driver should do the
same.

-- 

John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-alpha" in the body of the message