Date: Mon, 17 Dec 2001 13:09:41 -0800 (PST) From: John Baldwin <jhb@FreeBSD.org> To: Jake Burkholder <jake@locore.ca> Cc: alpha@FreeBSD.ORG, Adam Kranzel <adam@blacktabby.org>, Joerg Wunsch <joerg_wunsch@uriah.heep.sax.de> Subject: Re: Kernel builds broken? Message-ID: <XFMail.011217130941.jhb@FreeBSD.org> In-Reply-To: <20011217161037.F39205@locore.ca>
next in thread | previous in thread | raw e-mail | index | archive | help
On 17-Dec-01 Jake Burkholder wrote: >> > It looks like the ifdefs to skip some of the code for non-i386 are >> > broken. >> > >> > #if _MACHINE_ARCH == i386 in fd_probe() should be #ifdef __i386__. >> >> Normally not. #ifdef __i386__ would match the host system type, not >> the target system. > > Hmm. I think that the build system will do this correctly. The > define for the machine arch is in the compiler specs, so if you > build with a cross compiler targeting alpha on an i386, it will > correctly define __alpha__. All of the other ifdefs of this form > in the tree are as I describe. Yep. >> Why is _MACHINE_ARCH == i386 on an Alpha system? > > Maybe because its spelt MACHINE_ARCH? I don't know if these defines > even exist as preprocessor directives, I only know of the make variable. > As I said, the definition for the machine type is in the compiler specs > and is __<machine>__. Yes, we use __<machine>__ all over the kernel. The fd(4) driver should do the same. -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-alpha" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.011217130941.jhb>