From owner-p4-projects@FreeBSD.ORG Mon Oct 1 19:31:45 2007 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id BD63D16A46B; Mon, 1 Oct 2007 19:31:44 +0000 (UTC) Delivered-To: perforce@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4AF1216A421 for ; Mon, 1 Oct 2007 19:31:44 +0000 (UTC) (envelope-from hselasky@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 4D69E13C447 for ; Mon, 1 Oct 2007 19:31:44 +0000 (UTC) (envelope-from hselasky@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l91JViIp026551 for ; Mon, 1 Oct 2007 19:31:44 GMT (envelope-from hselasky@FreeBSD.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l91JViwF026548 for perforce@freebsd.org; Mon, 1 Oct 2007 19:31:44 GMT (envelope-from hselasky@FreeBSD.org) Date: Mon, 1 Oct 2007 19:31:44 GMT Message-Id: <200710011931.l91JViwF026548@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to hselasky@FreeBSD.org using -f From: Hans Petter Selasky To: Perforce Change Reviews Cc: Subject: PERFORCE change 127073 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Oct 2007 19:31:45 -0000 http://perforce.freebsd.org/chv.cgi?CH=127073 Change 127073 by hselasky@hselasky_laptop001 on 2007/10/01 19:31:37 Remove misleading comments. There is no limitation on the buffer size hence we are using the "proxy_buffer" flag. Affected files ... .. //depot/projects/usb/src/sys/dev/ata/ata-usb.c#19 edit .. //depot/projects/usb/src/sys/dev/usb/umass.c#25 edit Differences ... ==== //depot/projects/usb/src/sys/dev/ata/ata-usb.c#19 (text) ==== @@ -48,7 +48,7 @@ #include #include -#define ATAUSB_BULK_SIZE (1<<17) /* don't set this lower than (1 << 16) */ +#define ATAUSB_BULK_SIZE (1<<17) /* Command Block Wrapper */ struct bbb_cbw { ==== //depot/projects/usb/src/sys/dev/usb/umass.c#25 (text+ko) ==== @@ -156,7 +156,7 @@ #define DPRINTF(...) do { } while (0) #endif -#define UMASS_BULK_SIZE (1 << 17) /* bytes, must not be less than (1<<16) */ +#define UMASS_BULK_SIZE (1 << 17) #define UMASS_CBI_DIAGNOSTIC_CMDLEN 12 /* bytes */ #define UMASS_MAX_CMDLEN MAX(12, CAM_MAX_CDBLEN) /* bytes */