Date: Tue, 24 Oct 2000 09:06:59 -0400 From: Chris Faulhaber <jedgar@fxp.org> To: Jeroen Ruigrok van der Werven <jruigrok@via-net-works.nl> Cc: audit@freebsd.org Subject: Re: printjob.c mktemp() problem Message-ID: <20001024090659.A80998@peitho.fxp.org> In-Reply-To: <20001024140510.G93799@lucifer.bart.nl>; from jruigrok@via-net-works.nl on Tue, Oct 24, 2000 at 02:05:10PM %2B0200 References: <20001024140510.G93799@lucifer.bart.nl>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Oct 24, 2000 at 02:05:10PM +0200, Jeroen Ruigrok van der Werven wrote: > In printjob.c in the dir src/usr.sbin/lpr/lpd we see a mktemp() call > which creates a file accroding to the template. > > I also see that it is getting unlink()'d again a bunch of lines later. > > I later on see some open() call on the same tempfile array which does > exactly what the mktemp(3) manpage warns about. > > Am I right into thinking this might be a good candidate for a > mktemp()->mkstemp() conversion? > It looks like a prime candidate for mktemp()->mkstemp() conversion. -- Chris D. Faulhaber - jedgar@fxp.org - jedgar@FreeBSD.org -------------------------------------------------------- FreeBSD: The Power To Serve - http://www.FreeBSD.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20001024090659.A80998>