From owner-freebsd-bugs  Tue Dec  1 21:45:16 1998
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Received: (from majordom@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id VAA11798
          for freebsd-bugs-outgoing; Tue, 1 Dec 1998 21:45:16 -0800 (PST)
          (envelope-from owner-freebsd-bugs@FreeBSD.ORG)
Received: from root.com (root.com [198.145.90.17])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id VAA11788
          for <freebsd-bugs@FreeBSD.ORG>; Tue, 1 Dec 1998 21:45:14 -0800 (PST)
          (envelope-from root@root.com)
Received: from root.com (localhost [127.0.0.1])
	by root.com (8.8.8/8.8.5) with ESMTP id VAA03985;
	Tue, 1 Dec 1998 21:45:43 -0800 (PST)
Message-Id: <199812020545.VAA03985@root.com>
To: Dmitrij Tejblum <dima@tejblum.dnttm.rssi.ru>
cc: freebsd-bugs@FreeBSD.ORG
Subject: Re: mmap of large files 
In-reply-to: Your message of "Wed, 02 Dec 1998 03:21:11 +0300."
             <199812020021.DAA00861@tejblum.dnttm.rssi.ru> 
From: David Greenman <dg@root.com>
Reply-To: dg@root.com
Date: Tue, 01 Dec 1998 21:45:42 -0800
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org

>Does the test
>	if ((pos + size > (vm_offset_t)-PAGE_SIZE) ||
>in the mmap syscall have any purpose, other than break mmap with 
>pos > 4GB?

   I think the code is wrong. I think it should be (addr + size) and comparing
against -PAGE_SIZE is probably also wrong - careful attention needs to be
paid to rounding and overflow issues here. Needs more analysis.

-DG

David Greenman
Co-founder/Principal Architect, The FreeBSD Project

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message