From owner-svn-ports-all@freebsd.org Sat Sep 19 15:23:50 2015 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DE04BA05534; Sat, 19 Sep 2015 15:23:50 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id CF18A14E6; Sat, 19 Sep 2015 15:23:50 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1033) id CE42E13F8; Sat, 19 Sep 2015 15:23:50 +0000 (UTC) Date: Sat, 19 Sep 2015 15:23:50 +0000 From: Alexey Dokuchaev To: wenheping Cc: heping wen , "ports-committers@freebsd.org" , "svn-ports-all@freebsd.org" , "svn-ports-head@freebsd.org" Subject: Re: svn commit: r397327 - head/textproc/utf8proc Message-ID: <20150919152350.GA91306@FreeBSD.org> References: <201509191415.t8JEFZsv027725@repo.freebsd.org> <20150919143043.GA69287@FreeBSD.org> <20150919151048.GA87589@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150919151048.GA87589@FreeBSD.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 Sep 2015 15:23:51 -0000 On Sat, Sep 19, 2015 at 03:10:48PM +0000, Alexey Dokuchaev wrote: > On Sat, Sep 19, 2015 at 11:06:56PM +0800, wenheping wrote: > > > Guys, please bear in mind that Kato's patches often contain unrelated > > > changes and should always be reviewed thoroughly before applying. > > > > Sorry I do not agree with you this time. > > > > There are 5 lines in the PLIST_FILES example in Porter's Handbook, then > > I think 6 lines is acceptable. > > *sigh* (I'm not even going to point out that 6 > 5); your logic could be > OK for a new port, but things were already perfectly fine, so this change > was totally gratuitous and uncalled for. To elaborate further: commit log stated "Update to 1.3", that's all. Even if you did consider making any changes unrelated to actual version upgrade, they should've been mentioned in the log with adequate explanation why they were necessary or desired. This was not done, and this happens very often when Kato's PR get committed. ./danfe