From owner-svn-src-head@FreeBSD.ORG  Mon Jun  8 15:33:47 2009
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E31AA1065674;
	Mon,  8 Jun 2009 15:33:47 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42])
	by mx1.freebsd.org (Postfix) with ESMTP id B22698FC17;
	Mon,  8 Jun 2009 15:33:47 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net
	[66.111.2.69])
	by cyrus.watson.org (Postfix) with ESMTPSA id 4FA9846B3B;
	Mon,  8 Jun 2009 11:33:47 -0400 (EDT)
Received: from jhbbsd.hudson-trading.com (unknown [209.249.190.8])
	by bigwig.baldwin.cx (Postfix) with ESMTPA id 175CF8A069;
	Mon,  8 Jun 2009 11:33:46 -0400 (EDT)
From: John Baldwin <jhb@freebsd.org>
To: Jaakko Heinonen <jh@saunalahti.fi>
Date: Mon, 8 Jun 2009 10:17:53 -0400
User-Agent: KMail/1.9.7
References: <200906041618.n54GI851097005@svn.freebsd.org>
	<20090606090141.GA805@a91-153-125-115.elisa-laajakaista.fi>
In-Reply-To: <20090606090141.GA805@a91-153-125-115.elisa-laajakaista.fi>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200906081017.54171.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1
	(bigwig.baldwin.cx); Mon, 08 Jun 2009 11:33:46 -0400 (EDT)
X-Virus-Scanned: clamav-milter 0.95.1 at bigwig.baldwin.cx
X-Virus-Status: Clean
X-Spam-Status: No, score=-2.5 required=4.2 tests=AWL,BAYES_00,RDNS_NONE
	autolearn=no version=3.2.5
X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org, Paul Saab <ps@freebsd.org>
Subject: Re: svn commit: r193440 - in head/sys:
	cddl/contrib/opensolaris/uts/common/fs/zfs kern sys
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 08 Jun 2009 15:33:48 -0000

On Saturday 06 June 2009 5:01:41 am Jaakko Heinonen wrote:
> 
> Hi,
> 
> On 2009-06-04, Paul Saab wrote:
> >   Support shared vnode locks for write operations when the offset is
> >   provided on filesystems that support it.  This really improves mysql
> >   + innodb performance on ZFS.
> 
> The panic below looks related to this commit. I think the assert is only
> enabled when DEBUG_VFS_LOCKS is defined.

Yes, vnode_if.src needs to be changed:

%% write	vp	E E E
%! write	pre	VOP_WRITE_PRE
%! write	post	VOP_WRITE_POST

vop_write {
	IN struct vnode *vp;
	INOUT struct uio *uio;
	IN int ioflag;
	IN struct ucred *cred;
};

The 'E E E' should be 'L L L'.

-- 
John Baldwin