From owner-freebsd-geom@FreeBSD.ORG Thu Aug 10 14:05:27 2006 Return-Path: X-Original-To: freebsd-geom@FreeBSD.org Delivered-To: freebsd-geom@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 64F7016A4DF; Thu, 10 Aug 2006 14:05:27 +0000 (UTC) (envelope-from cswiger@mac.com) Received: from pi.codefab.com (pi.codefab.com [199.103.21.227]) by mx1.FreeBSD.org (Postfix) with ESMTP id CE88143D70; Thu, 10 Aug 2006 14:05:26 +0000 (GMT) (envelope-from cswiger@mac.com) Received: from localhost (localhost [127.0.0.1]) by pi.codefab.com (Postfix) with ESMTP id 3EBC25CB6; Thu, 10 Aug 2006 10:05:26 -0400 (EDT) X-Virus-Scanned: amavisd-new at codefab.com Received: from pi.codefab.com ([127.0.0.1]) by localhost (pi.codefab.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PPna4MOjhCCy; Thu, 10 Aug 2006 10:05:25 -0400 (EDT) Received: from [192.168.1.251] (pool-68-161-117-245.ny325.east.verizon.net [68.161.117.245]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by pi.codefab.com (Postfix) with ESMTP id CD2CF5C6E; Thu, 10 Aug 2006 10:05:24 -0400 (EDT) Message-ID: <44DB3D1A.1030605@mac.com> Date: Thu, 10 Aug 2006 10:05:14 -0400 From: Chuck Swiger User-Agent: Thunderbird 1.5.0.5 (Windows/20060719) MIME-Version: 1.0 To: =?ISO-8859-1?Q?Dag-Erling_Sm=F8rgrav?= References: <20060808195202.GA1564@garage.freebsd.pl> <20060808210211.GA730@bsd.trippelsdorf.de> <20060808214116.GB730@bsd.trippelsdorf.de> <868xlw3e2z.fsf@xps.des.no> In-Reply-To: <868xlw3e2z.fsf@xps.des.no> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit Cc: freebsd-fs@FreeBSD.org, freebsd-current@FreeBSD.org, freebsd-geom@FreeBSD.org Subject: Re: GJournal (hopefully) final patches. X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Aug 2006 14:05:27 -0000 Dag-Erling Smørgrav wrote: > Markus Trippelsdorf writes: >> Adding -fno-strict-aliasing to the CFLAGS of sbin/fsck_ffs/Makefile >> solved the problem for now. > > -fno-strict-aliasing does not solve anything, it just prevents the > compiler from telling you about bugs in your code. It also prevents the compiler's optimizer from assuming that a pointer dereference may impact datatypes of other sizes. Since there exists C code that changes, say, int16_t's or int32_t's one byte at a time, using that flag prevents the compiler from generating buggy executables from C sources which do not adhere to the assumptions made by "strict aliasing". -- -Chuck