From nobody Sat Apr 29 07:37:33 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Q7hC20Gqxz48cVG; Sat, 29 Apr 2023 07:37:34 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Q7hC16PbTz3J3N; Sat, 29 Apr 2023 07:37:33 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1682753853; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=2QtW98n5Rx0CbfsCu6rjDmKqk845YW5JWPIyw89SurQ=; b=D+cJw/ZvhsoUZJBRWGVcSykVI0VUgY32+VmcWRJ49R+ZiEMJCidlNzvoeSx0DNX2EpTK/Z Iyc+swlnSAqu/UQpDBUvXI6Kg+/0Q/unDAcqpMhu+frtz8jXYQjGoHbIINeqTC+coQcmkB 6HtEfwrnASTmc1PaAvVpfpVYMlKiFYFEkJbqCO3EmaIUvvzmaffwFnY07Ba5JnB8fQXS25 Yt9uJwVVQbMk5mFDxMM/qzuY613spxr9VLFa2PALRVoDa9DtO31fzdX53H8sL8cWLcIXDp IqgUtbR5jk6XuH2/6hx7V3W03ijbaLGaTxuW4LusRq+A26K7GtL43rzFuj5VQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1682753853; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=2QtW98n5Rx0CbfsCu6rjDmKqk845YW5JWPIyw89SurQ=; b=Onk27OAhjl7jopqIgDrKSPztNslyx4xl9c9gtb9cAEpSMqgAqvizR3lUEgLRtXYWeA/1Uu 1aJrZloxSRY86XnfVkirtXs9qNHnfWL8+j9aWDNZc67h5fCyCFddgAGNN0gl0yeu8Y1vyW FFDy12O3LKU+OTMQMKIf7kNoO2gq1UfeXUn3VMqsKOXecfHwxHFwIMnqrOARj7l0KVE/Cg Q0iDYZypxjYx+dTqfKFRUV1v8GpE8EUzDTAS+/F0wUrIZZkuYmcXqwDSqPMOy38FG+ISsv uZHF7CfcO1z0StH24QGSL91T3qzBBjWlT7u+UqW8otbhX3yhzBJiVUgKStcgMA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1682753853; a=rsa-sha256; cv=none; b=GjPRWWPjcudSQaSWUFmjrSJ9TmQjPymFvi//g9rQIcjg/89d+x66n4AGzqiFlhnxKp/yqR 2KYL/vKAranB4bxi0xWU1XIkcu6kb+o9Va39KskaMabTaQW9eiQYElOoz6FOtLfBXuUHqL KQQoWOOw1BAJtGQalXysy10jViqz1SJNtvEAo7Njh9Gnce97m6wZWqF1LuSvW6gVetVr4J B5cmPNbjvYYQmxFS5HA59m/yBD9d1d2MPFxTKBxpUJ+OiViZn9xY5QH+F0+nGFPTzd7Pru BRpJ/M8eWQzvUuTFoD80pBbWkK/3PU+Ust8aI7y85w+2ibfZ+Mg7XgviMmc2Pw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Q7hC15N0JzYR4; Sat, 29 Apr 2023 07:37:33 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 33T7bXXC064500; Sat, 29 Apr 2023 07:37:33 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 33T7bXKq064499; Sat, 29 Apr 2023 07:37:33 GMT (envelope-from git) Date: Sat, 29 Apr 2023 07:37:33 GMT Message-Id: <202304290737.33T7bXKq064499@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Dimitry Andric Subject: git: d5ee36dbb272 - stable/12 - Suppress lld 16 errors about undefined symbols in version maps List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dim X-Git-Repository: src X-Git-Refname: refs/heads/stable/12 X-Git-Reftype: branch X-Git-Commit: d5ee36dbb27222e9b3bd57c5ffc5cff5667c2e2e Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch stable/12 has been updated by dim: URL: https://cgit.FreeBSD.org/src/commit/?id=d5ee36dbb27222e9b3bd57c5ffc5cff5667c2e2e commit d5ee36dbb27222e9b3bd57c5ffc5cff5667c2e2e Author: Dimitry Andric AuthorDate: 2023-04-17 16:00:20 +0000 Commit: Dimitry Andric CommitDate: 2023-04-29 07:24:32 +0000 Suppress lld 16 errors about undefined symbols in version maps lld >= 16 turned on --no-undefined-version by default, which results in errors whenever symbols are mentioned in version maps, but are not actually defined in the binary. Since we have quite a few instances of symbols that are defined or not, depending on various compile-time settings, suppress this lld check for the time being. MFC after: 1 week (cherry picked from commit 2ba84b4bcdd6012e8cfbf8a0d060a4438623a638) --- share/mk/bsd.lib.mk | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/share/mk/bsd.lib.mk b/share/mk/bsd.lib.mk index 69b64200e47f..c472a4add8f6 100644 --- a/share/mk/bsd.lib.mk +++ b/share/mk/bsd.lib.mk @@ -223,6 +223,13 @@ SHLIB_NAME_FULL=${SHLIB_NAME} .if ${MK_SYMVER} == "yes" && !empty(VERSION_MAP) ${SHLIB_NAME_FULL}: ${VERSION_MAP} LDFLAGS+= -Wl,--version-script=${VERSION_MAP} + +# lld >= 16 turned on --no-undefined-version by default, but we have several +# symbols in our version maps that may or may not exist, depending on +# compile-time defines. +.if ${LINKER_TYPE} == "lld" && ${LINKER_VERSION} >= 160000 +LDFLAGS+= -Wl,--undefined-version +.endif .endif .if defined(LIB) && !empty(LIB) || defined(SHLIB_NAME)